1065379 - build fails on ppc64le

Status: RESOLVED DUPLICATE of bug 1014375

(Firefox Build System :: General, defect)

Description

[Jakub Čajka]

Attachment: ppc64le-build-fix.patch

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Firefox/31.0
Build ID: 20140730101922

Steps to reproduce:

build firefox-32.0 from source on ppc64le


Actual results:

build fails with lot of undefined stuff in Value.h

small except from build log:
.
.
.
In file included from /builddir/build/BUILD/firefox-32.0/mozilla-release/js/src/jsalloc.h:18:0,
                 from /builddir/build/BUILD/firefox-32.0/mozilla-release/js/src/jsatom.h:12,
                 from /builddir/build/BUILD/firefox-32.0/mozilla-release/js/src/vm/Runtime.h:20,
                 from /builddir/build/BUILD/firefox-32.0/mozilla-release/js/src/jscntxt.h:15,
                 from /builddir/build/BUILD/firefox-32.0/mozilla-release/js/src/vm/RegExpObject.h:13,
                 from /builddir/build/BUILD/firefox-32.0/mozilla-release/js/src/builtin/RegExp.h:10,
                 from /builddir/build/BUILD/firefox-32.0/mozilla-release/js/src/builtin/RegExp.cpp:7:
../../dist/include/js/Value.h:339:25: error: 'jsval_layout' was not declared in this scope
 JS_STATIC_ASSERT(sizeof(jsval_layout) == 8);
                         ^
../../dist/include/js/Utility.h:54:56: note: in definition of macro 'JS_STATIC_ASSERT'
 #define JS_STATIC_ASSERT(cond)           static_assert(cond, "JS_STATIC_ASSERT")
                                                        ^
In file included from ../../dist/include/js/CallArgs.h:39:0,
                 from ../../dist/include/js/CallNonGenericMethod.h:12,
                 from /builddir/build/BUILD/firefox-32.0/mozilla-release/js/src/NamespaceImports.h:15,
                 from /builddir/build/BUILD/firefox-32.0/mozilla-release/js/src/gc/Barrier.h:10,
                 from /builddir/build/BUILD/firefox-32.0/mozilla-release/js/src/jsatom.h:14,
                 from /builddir/build/BUILD/firefox-32.0/mozilla-release/js/src/vm/Runtime.h:20,
                 from /builddir/build/BUILD/firefox-32.0/mozilla-release/js/src/jscntxt.h:15,
                 from /builddir/build/BUILD/firefox-32.0/mozilla-release/js/src/vm/RegExpObject.h:13,
                 from /builddir/build/BUILD/firefox-32.0/mozilla-release/js/src/builtin/RegExp.h:10,
                 from /builddir/build/BUILD/firefox-32.0/mozilla-release/js/src/builtin/RegExp.cpp:7:
../../dist/include/js/Value.h:866:15: error: 'jsval_layout' does not name a type
 static inline jsval_layout JSVAL_TO_IMPL(JS::Value v);
.
.
.


Expected results:

build passes sucessfuly, in attachment is patch changing js/src/configure.in by slightly modifing define for powerpc64 to include ppc64le as similar changes are inplace for other defines, after this change build passes successfuly

Comment 1

[Landry Breuil (:gaston)]

Has probably been fixed in 33 and 34 by 1014375 - was too late to get fixed in 32.

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 8487184 [details] [diff] [review]
ppc64le-build-fix.patch

Clearing review flag per comment 9. Please let me know if there's more work to do here.