Closed
Bug 1065398
Opened 10 years ago
Closed 10 years ago
Error when using checksetup.pl to create BMO database from scratch when Review extension enabled
Categories
(bugzilla.mozilla.org :: Extensions, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: dkl, Assigned: dylan)
Details
Attachments
(1 file, 1 obsolete file)
|
588 bytes,
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
[snip]
Creating initial dummy product 'TestProduct'...
Odd number of elements in anonymous hash at ./extensions/Review/Extension.pm line 300.
Can't use string ("table") as an ARRAY ref while "strict refs" in use at ./extensions/Review/Extension.pm line 193.
Re-enabling Review after initial checksetup.pl and then running again works without error.
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → dylan
|
|
Assignee | |
Comment 1•10 years ago
|
||
The problem is with _new_users_from_input(). It is being called in list context, and features a bare return, which returns the empty list when called in list context. I don't think we need to differentiate between false and exists -- simple hash access doesn't auto-vivify,
|
|
Assignee | |
Comment 2•10 years ago
|
||
I don't encounter the error with this patch.
Attachment #8487248 -
Attachment is obsolete: true
Attachment #8487677 -
Flags: review?(dkl)
|
|
Assignee | |
Updated•10 years ago
|
Status: NEW → ASSIGNED
|
Reporter | |
Comment 3•10 years ago
|
||
Comment on attachment 8487677 [details] [diff] [review] bug-1065398-v2.patch Review of attachment 8487677 [details] [diff] [review]: ----------------------------------------------------------------- r=dkl
Attachment #8487677 -
Flags: review?(dkl) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git 58b7205..d4a04eb master -> master
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Component: Extensions: Review → Extensions
You need to log in
before you can comment on or make changes to this bug.
Description
•