Closed
Bug 1065401
Opened 11 years ago
Closed 11 years ago
[Gaia][STK] Put the result in isYesNo for the "Yes or No" GET_INKEY request.
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(blocking-b2g:1.4+, b2g-v1.4 fixed, b2g-v2.0 wontfix, b2g-v2.0M fixed, b2g-v2.1 fixed, b2g-v2.2 fixed)
People
(Reporter: edgar, Assigned: edgar)
References
Details
(Whiteboard: [sprd347118][FT:RIL])
Attachments
(1 file)
|
46 bytes,
text/x-github-pull-request
|
frsela
:
review+
bajaj
:
approval-gaia-v1.4+
bajaj
:
approval-gaia-v2.0-
fabrice
:
approval-gaia-v2.1+
|
Details | Review |
+++ This bug was initially created as a clone of Bug #1062720 +++
This bug is filed for Gaia, please see bug 1062720 comment #6 for the detail.
| Assignee | ||
Comment 1•11 years ago
|
||
[Blocking Requested - why for this release]: GCF STK 27.22.4.2.5/1 fail (GET INKEY). This bug is filed for Gaia part. Please see bug 1062720.
blocking-b2g: --- → 1.4?
| Assignee | ||
Updated•11 years ago
|
Assignee: nobody → echen
| Assignee | ||
Comment 2•11 years ago
|
||
| Assignee | ||
Updated•11 years ago
|
Attachment #8487969 -
Flags: review?(frsela)
Comment 4•11 years ago
|
||
Comment on attachment 8487969 [details] [review]
PR #23956
Thank you
Attachment #8487969 -
Flags: review?(frsela) → review+
| Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S5 (26sep)
| Assignee | ||
Comment 6•11 years ago
|
||
Comment on attachment 8487969 [details] [review]
PR #23956
NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): NA
[User impact] if declined: GCF STK ‘7.22.4.2.5/1’ fail (GET INKEY)
[Testing completed]: Partner had already help to test this patch.
[Risk to taking this patch] (and alternatives if risky): No
[String changes made]: No
Attachment #8487969 -
Flags: approval-gaia-v1.4?
Comment 7•11 years ago
|
||
Does this need to land on any other branches besides v1.4?
status-b2g-v1.4:
--- → affected
status-b2g-v2.0:
--- → ?
status-b2g-v2.0M:
--- → ?
status-b2g-v2.1:
--- → ?
status-b2g-v2.2:
--- → fixed
Flags: needinfo?(echen)
| Assignee | ||
Comment 8•11 years ago
|
||
Comment on attachment 8487969 [details] [review]
PR #23956
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #7)
> Does this need to land on any other branches besides v1.4?
Yes, I think it is valuable for all other branches.
[Approval Request Comment]
See comment #6.
Attachment #8487969 -
Flags: approval-gaia-v2.1?
Attachment #8487969 -
Flags: approval-gaia-v2.0?
Flags: needinfo?(echen)
| Assignee | ||
Updated•11 years ago
|
Updated•11 years ago
|
Attachment #8487969 -
Flags: approval-gaia-v2.1? → approval-gaia-v2.1+
Comment 9•11 years ago
|
||
Comment 10•11 years ago
|
||
Comment on attachment 8487969 [details] [review]
PR #23956
Approving on 1.4, will have to check with partner on 2.0
Attachment #8487969 -
Flags: approval-gaia-v1.4? → approval-gaia-v1.4+
Comment 11•11 years ago
|
||
Comment 12•11 years ago
|
||
Comment on attachment 8487969 [details] [review]
PR #23956
not taking on 2.0 for the same reason : https://bugzilla.mozilla.org/show_bug.cgi?id=1062720#c27. Flagging ka--zhen for 2.0M uplift
Attachment #8487969 -
Flags: approval-gaia-v2.0? → approval-gaia-v2.0-
Updated•11 years ago
|
Flags: needinfo?(kli)
Comment 13•11 years ago
|
||
Flags: needinfo?(kli)
Updated•11 years ago
|
| Assignee | ||
Updated•11 years ago
|
Whiteboard: sprd347118 → [sprd347118][FT:RIL]
You need to log in
before you can comment on or make changes to this bug.
Description
•