1065506 - cfx generates invalid paths in a .xpi for chrome files

Status: RESOLVED WONTFIX

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Anthony Shipman]

Attachment: fix

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101 Firefox/32.0
Build ID: 20140825202822

Steps to reproduce:

In version 1.17, cfx produces

       23  01-01-1980 00:00   locales.json                                             
        0  01-01-1980 00:00   /
    12775  07-15-2014 09:08   bootstrap.js
        0  01-01-1980 00:00   chrome/
       32  09-04-2014 17:38   chrome.manifest
        0  01-01-1980 00:00   chrome/content/
      126  09-04-2014 17:38   chrome/content/cdialog.css
     1425  09-04-2014 17:38   chrome/content/cdialog.xul
        0  01-01-1980 00:00   resources/

This is an invalid set of directories for the chrome tree.

A bug fix is attached. It produces

    12775  07-15-2014 09:08   bootstrap.js
        0  01-01-1980 00:00   chrome/
       32  09-04-2014 17:38   chrome.manifest
        0  01-01-1980 00:00   chrome/content/
      126  09-04-2014 17:38   chrome/content/cdialog.css
     1425  09-04-2014 17:38   chrome/content/cdialog.xul
        0  01-01-1980 00:00   chrome/locale/
        0  01-01-1980 00:00   chrome/skin/
        0  01-01-1980 00:00   resources/

Comment 1

[Dave Townsend [:mossop]]

What is invalid about it?

Comment 2

[Anthony Shipman]

(In reply to Dave Townsend [:mossop] from comment #1)
> What is invalid about it?

When I tried to upload the .xpi to addons.mozilla.org it rejected the .xpi
saying it was invalid, because of the "/" path in it.

Comment 3

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Erik since you have worked with AMO folks closely, would you mind looking into this ?

Comment 4

[Erik Vold [:erikvold] (please needinfo? me)]

(In reply to Irakli Gozalishvili [:irakli] [:gozala] [@gozala] from comment #3)
> Erik since you have worked with AMO folks closely, would you mind looking
> into this ?

You didn't ni me, so I didn't notice this until now, this has nothing to do with AMO though.

Comment 5

[Erik Vold [:erikvold] (please needinfo? me)]

We won't be releasing any new versions of cfx, jpm is the replacement https://www.npmjs.com/package/jpm