1065516 - [System] Remove window.self in appWindow to reflect the dependency

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Kevin Grandon :kgrandon]

It seems like we have a lot of invalid references to some magic variable `self` from within app_window.js. Not sure how these got here, but the usage is not clear so we should fix it.

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Just looking for a review here, thanks! This seems to impact testing as well, so we should try to get this into 2.1.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8487347 [details] [review]
Github pull request

I really prefer Alive to review this patch as he creates the |self| variable here.

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8487347 [details] [review]
Github pull request

window.self points to window object so it's not invalid.

Read https://developer.mozilla.org/en-US/docs/Web/API/Window.self

I am going to r+ it because we need to reflect the dependency of appWindow by putting global object in /* global */.

Comment 4

[Kevin Grandon :kgrandon]

(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #3)
> Comment on attachment 8487347 [details] [review]
> Github pull request
> 
> window.self points to window object so it's not invalid.
> 
> Read https://developer.mozilla.org/en-US/docs/Web/API/Window.self
> 
> I am going to r+ it because we need to reflect the dependency of appWindow
> by putting global object in /* global */.

Thanks Alive, that makes sense now. I think that reflecting the global usage in /* global */ will help us in the future.

We also may have another bug then, there was a bug reported over IRC that self.AppChrome was undefined. I assumed that this was because of a leaked `self` variable, but I could be wrong. In any case, we can land this and I'll also try to track down if there's a case where AppChrome can be null while we're instantiating an app window.

Comment 5

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/68e2fb96c725d434eb21040b718dc2a11321dbe9

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8487347 [details] [review]
Github pull request

I would like to uplift this to 2.1 because although minor, it should help us debug a reported error when creating an app window.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Cleanup of existing code.
[User impact] if declined: None, but this may help us find and fix a user-facing error.
[Testing completed]: Manual testing.
[Risk to taking this patch] (and alternatives if risky): Low risk, only semantic changes.
[String changes made]: None.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/5b009c0624d28889c5dd41ed2e4f48c174e3c41c