1065518 - Turn off geo.wifi.logging.enabled by default (silencing "*** WIFI GEO:" terminal-spam)

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Description

[Daniel Holbert [:dholbert] (PTO until 2/24)]

STR:
 1. Start nightly build from the terminal.
 2. Visit http://html5demos.com/geo and click "share location"

ACTUAL RESULTS: A bunch of logging appears in my terminal:
{
*** WIFI GEO: startup called.
*** WIFI GEO: Use request cache:false reason:No cached data
*** WIFI GEO: Sending request
*** WIFI GEO: sending {"wifiAccessPoints":[]}
*** WIFI GEO: gls returned status: 404 --> {"error":{"errors":[{"domain":"geolocation","reason":"notFound","message":"Not Found"}],"code":404,"message":"Not Found"}}
*** WIFI GEO: Use request cache:false reason:No cached data
*** WIFI GEO: Sending request
*** WIFI GEO: sending {}
*** WIFI GEO: gls returned status: 404 --> {"error":{"errors":[{"domain":"geolocation","reason":"notFound","message":"Not Found"}],"code":404,"message":"Not Found"}}
*** WIFI GEO: shutdown called
}

EXPECTED RESULTS: no logging, unless I explicitly asked for it. (Firefox's terminal-output should be quiet, by default.)


It looks like this logging is controlled by the pref "geo.wifi.logging.enabled", which was made on-by-default in Nightly/Aurora builds, apparently because we needed it to debug some issue back in bug 977725.


Doug / Fabrice, can we turn this pref off (by default) in Nightly builds now? I'm not sure what value we get from logging to the terminal every time a user triggers some geolocation stuff, unless they're specifically wanting to diagnose something (in which case they can turn on the pref and opt-in to the logging).

Comment 1

[Daniel Holbert [:dholbert] (PTO until 2/24)]

The pref lives here, BTW:
>1640 #ifdef RELEASE_BUILD
>1641 pref("geo.wifi.logging.enabled", false);
>1642 #else
>1643 pref("geo.wifi.logging.enabled", true);
>1644 #endif
http://mxr.mozilla.org/mozilla-central/source/browser/app/profile/firefox.js?rev=b074336ad3f1#1643

Also: based on bug 977725 comment 8 ("I removed the logging preference."), I wonder if these pref lines weren't intended to actually land.... 

It looks like the previous revision of the patch had these lines in b2g.js and firefox.js, and then the landed cset (with the "I removed the logging preference" comment) had the line removed from b2g.js, but not from firefox.js.

Comment 2

[Daniel Holbert [:dholbert] (PTO until 2/24)]

Attachment: fix v1: remove this chunk from firefox.js

Assuming my hunch from comment 1 is right, here's a patch to remove these probably-not-indended-to-have-landed lines.

Comment 3

[:garvan]

In the Gaia debug screen, there is a UI switch to turn this on. I suspect this switch was missing when this code landed.

Comment 4

[Daniel Holbert [:dholbert] (PTO until 2/24)]

That may be the case, though that's somewhat tangential -- the file where these prefs were added (browser/app/profile/firefox.js) has no effect on B2G/gaia. It establishes pref-defaults *only* for desktop Firefox, as far as I know.

Comment 5

[:garvan]

Oops, nevermind, brain is stuck in B2G mode ATM.

Comment 6

[Daniel Holbert [:dholbert] (PTO until 2/24)]

Comment on attachment 8487346 [details] [diff] [review]
fix v1: remove this chunk from firefox.js

Fabrice, maybe you can get to this before Doug does -- can we turn off this logging and make it opt-in?

(Per comment 1, I'm pretty sure it wasn't ultimately intended to land default-enabled like this.)

Comment 7

[Daniel Holbert [:dholbert] (PTO until 2/24)]

Thanks, Fabrice -- landed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3749c4d4e76b

Comment 8

[Hanno Schlichting]

The patch actually landed and geo logging is disabled by default.