1065523 - Locale picker screen displays short locale display name, not capitalized region-decorated name

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Locale switching and selection, defect)

Description

[Robin Andersen [:tecgirl]]

Attachment: The Language screen from Nightly

When choosing an English language, I am able to choose from:
Release: UK, US / Beta: UK, US / Aurora: South Africa, UK, US / Nightly: US only (??)

When choosing a region of the English language the Language screen displays only "English" and not the region to let the user know which variant they've chosen.

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

Are you using an en-US only build? The multi locale build is at http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/latest-mozilla-central-android/fennec-35.0a1.multi.android-arm.apk and using it I have many languages to choose from.

Comment 2

[Richard Newman [:rnewman]]

I think there are two things here:

* Nightly doesn't package most of our locales. The only English dialect we ship in Nightly is en_US. Localizers work on Aurora and up.

* We use the locale's own display string in the locale picker label. These tend to be short (and non-capitalized, which was half fixed in Bug 1014602).

I assume you're mainly concerned about the latter?

Comment 3

[Robin Andersen [:tecgirl]]

Perhaps I should have included the screenshot from Aurora, where I chose South African English, and on the Language screen just "English" is displayed. Yes, the concern is that if more than one variant is available then we should display it.

Comment 4

[Richard Newman [:rnewman]]

Attachment: Part 0: enable KitKat-specific code in locale picker. v1

Dep landed, I'm touching this file, so might as well fix this. Works on my KitKat device.

Comment 5

[Richard Newman [:rnewman]]

Attachment: Part 1: locale picker screen displays short locale display name, not capitalized region-decorated name. v1

What I think was happening here: we were taking a locale *tag* ("en-US") and giving it to the Java Locale constructor to parse. It parsed that as "en" (because it expects _ not -), so we'd get "English".

And because it was the display string from the locale, in e.g., French we'd get "français", lowercase.

The fix is to just use the same code path that we use for the list picker itself -- make a descriptor from the tag, and ask it for its display string.

Comment 6

[Nick Alexander :nalexander [he/him] (PTO August 22-September 12)]

Comment on attachment 8487372 [details] [diff] [review]
Part 0: enable KitKat-specific code in locale picker. v1

Review of attachment 8487372 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm.

Comment 7

[Nick Alexander :nalexander [he/him] (PTO August 22-September 12)]

Comment on attachment 8487376 [details] [diff] [review]
Part 1: locale picker screen displays short locale display name, not capitalized region-decorated name. v1

Review of attachment 8487376 [details] [diff] [review]:
-----------------------------------------------------------------

Include the helpful explanation in the commit comment; and will there be a Part 2?

Comment 8

[Richard Newman [:rnewman]]

(In reply to Nick Alexander :nalexander from comment #7)

> Include the helpful explanation in the commit comment; and will there be a
> Part 2?

Nope, only 0 and 1 :)

Comment 9

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/37ed4ec67482
https://hg.mozilla.org/integration/fx-team/rev/9aa76517b185

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/37ed4ec67482
https://hg.mozilla.org/mozilla-central/rev/9aa76517b185

Comment 11

[Richard Newman [:rnewman]]

Comment on attachment 8487376 [details] [diff] [review]
Part 1: locale picker screen displays short locale display name, not capitalized region-decorated name. v1

Approval Request Comment
[Feature/regressing bug #]:
  Original locale picker work in 32.

[User impact if declined]:
  Displayed locale in Settings will omit region, won't be capitalized.

[Describe test coverage new/current, TBPL]:
  Manual.

[Risks and why]: 
  Very low risk: just uses the same text display for the picker itself as we do for the list contents.

[String/UUID change made/needed]:
  None.

Comment 12

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8487376 [details] [diff] [review]
Part 1: locale picker screen displays short locale display name, not capitalized region-decorated name. v1

Aurora+

Given that this shipped in 32, should/can we uplift to beta 33 as well?

Comment 13

[Richard Newman [:rnewman]]

Comment on attachment 8487376 [details] [diff] [review]
Part 1: locale picker screen displays short locale display name, not capitalized region-decorated name. v1

(In reply to Lawrence Mandel [:lmandel] from comment #12)

> Given that this shipped in 32, should/can we uplift to beta 33 as well?

If you're happy with the risk (very low) for the reward (could be regarded as polish), then yes, I'd take this for beta.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c69612e0f675
https://hg.mozilla.org/releases/mozilla-beta/rev/cea1db6ec4ac