1065585 - [SMS Messenger] After closing messenger and reopening with text typed into a message leads to keyboard and auto correct issues.

Status: RESOLVED DUPLICATE of bug 1043682

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[[:RJ]]

Attachment: log cat

Description:
 After closing messenger and reopening with text typed into a message with at least one full word, issues with key commands occur, such as when first hitting the space bar after relaunch instead of adding a space, it creates a new line after which backspace can go farther back then intended, and going to original word hitting space next to the word, activating the auto correct, this will add a second capital letter of the word to the front of the word    


Repro Steps:
1) Update a Flame to 20140910000202
2) Open the messenger app and start a new message 
3) Type in a full word ( for bug the word “Firefox” was used) 
4) When complete tap home button > close messenger via card view
5) Reopen messenger app and open the message user has full word typed into
6) Press space bar, hit backspace and attempt to use auto correct on typed out word  


Actual:
Space bar starts a new line, backspace can go back farther then intended and auto correct adds an extra first letter to the word


Expected:
Normal behaviour, space bar adds once blank space, backspace has limits to how far it can go on screen and auto correct does not add an extra first letter.

Environmental Variables:
Device: Flame 2.1 (319mb)
Build ID: 20140910000202
Gaia: 79dc972d637ff5ef7667b231e93118b4ed83ba9c
Gecko: 0890010015a2
Version: 34.0a2 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0


Repro frequency:100%

See attached: video clip, logcat
http://youtu.be/1fVqlV8WnR8

Comment 1

[[:RJ]]

This issue DOES occur on Flame 2.2 (319mb),Open C 2.2, Flame 2.1(512mb), Open C 2.1, 

After closing messenger and reopening with text typed into a message leads to keyboard and auto correct issues. 

Flame 2.2

Environmental Variables:
Device: Flame Master (319mb)
BuildID: 20140910040203
Gaia: 8e02f689b0fc39cb6ccdc22d02ed7e219c58faa7
Gecko: 152ef25e89ae
Version: 35.0a1 (Master) 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Open C 2.2

Environmental Variables:
Device: Open_C Master
BuildID: 20140910040203
Gaia: 8e02f689b0fc39cb6ccdc22d02ed7e219c58faa7
Gecko: 152ef25e89ae
Version: 35.0a1 (Master) 
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Flame 2.1

Environmental Variables:
Device: Flame 2.1
BuildID: 20140910000202 (512mb) 
Gaia: 79dc972d637ff5ef7667b231e93118b4ed83ba9c
Gecko: 0890010015a2
Version: 34.0a2 (2.1)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Open C 2.1

Environmental Variables:
Device: Open_C 2.1
BuildID: 20140910000202
Gaia: 79dc972d637ff5ef7667b231e93118b4ed83ba9c
Gecko: 0890010015a2
Version: 34.0a2 (2.1) 
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

This issue does not occur on Flame 2.0(319mb), and Open C 2.0 Flame 1.4 (319mb) 1.4 Open C

there is no odd spacings or extra letters present after reopening 

Flame 2.0

Environmental Variables:
Device: Flame 2.0 (319mb)
BuildID: 20140910000203
Gaia: 3f4c635106c5364228782d12b1cb76b0c105b971
Gecko: 02a5b9234c13
Version: 32.0 (2.0) 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Open_C 2.0

Enviromental Variables:
Device: Open_C 2.0
BuildID: 20140910000203
Gaia: 3f4c635106c5364228782d12b1cb76b0c105b971
Gecko: 02a5b9234c13
Version: 32.0 (2.0)
Firmware: P821A10v1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Flame 1.4

Environmental Variables:
Device: Flame 1.4 (319mb)
BuildID: 20140910000204
Gaia: 6018a1c18f0c3eab25aac2ba3064904740591dd2
Gecko: 90e68c490bf9
Version: 30.0 (1.4) 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Open C 1.4

Environmental Variables:
Device: Open_C 1.4
BuildID: 20140910000204
Gaia: 6018a1c18f0c3eab25aac2ba3064904740591dd2
Gecko: 90e68c490bf9
Version: 30.0 (1.4) 
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Comment 2

[Julien Wajsberg [:julienw]]

Looks like either a Keyboard or contenteditable issue.

Comment 3

[Maria Angeles Oteo (:oteo)]

Triage: Following triage rules this issue should not block the release  although it's a regression and an ugly bug. Ask for approval to 2.1 when you have the patch, please.

Comment 4

[Maria Angeles Oteo (:oteo)]

Julien, this patch should be addressed by the Keyboard team?

Comment 5

[Julien Wajsberg [:julienw]]

I'm not sure, this may be an issue in SMS too. Let's request a regression window (I forgot to add the flag earlier).

[Blocking Requested - why for this release]: requesting blocker status again. I don't understand why such a bug is not a blocker. It's a clear regression, clear UX annoyance, for a frequent use case, and we clearly are at the start of the stabilization phase for v2.1.

Comment 6

[Pi Wei Cheng [:piwei] (inactive)]

b2g-inbound regression window:

Last Working Environmental Variables:
Device: Flame
BuildID: 20140625073205
Gaia: 7b52501d6e46edca243ec505f835f05e82cfd6d0
Gecko: 60d8e80d67ab
Version: 33.0a1 (2.1)
Firmware: V123

First Broken Environmental Variables
Device: Flame
BuildID: 20140625083205
Gaia: ef9a48acb5c30dd8ddac65f765d15df707dfa7db
Gecko: f13b6b220f25
Version: 33.0a1 (2.1)
Firmware: V123

First broken gaia & Last working gecko - issue DOES repro
Gaia: ef9a48acb5c30dd8ddac65f765d15df707dfa7db
Gecko: 60d8e80d67ab

First broken gecko & Last working gaia - issue does NOT repro
Gaia: 7b52501d6e46edca243ec505f835f05e82cfd6d0
Gecko: f13b6b220f25

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/7b52501d6e46edca243ec505f835f05e82cfd6d0...ef9a48acb5c30dd8ddac65f765d15df707dfa7db

Caused by bug 959201.

Comment 7

[Joshua Mitchell (Inactive)]

Possibly caused by bug 959201 - 

The patch author - Lana Huong Scravaglieri does not have any contact info in Github and I'm not seeing her here in Bugzilla either - Julien - because you are already looking into this bug would you mind taking over here?

Comment 8

[Julien Wajsberg [:julienw]]

Thanks, this is indeed a good culprit.

Lana is a contributor and I don't want to bug her :) so someone from the SMS team will pick it from here, thanks !

Comment 9

[Julien Wajsberg [:julienw]]

After trying the bug myself, I think bug 959201 just exposed the bug, so I'm removing it from the "blocks" line.

Hey Luke, I know you looked at such issues recently, maybe you can have a look as well? I'd like to especially know if this is a bug in SMS or in contenteditable or in keyboard. If it's not in SMS maybe we can still work around it (for example by slightly changing where we set the cursor in bug 959201). Thanks !

Comment 10

[Luke Chang [:lchang] (inactive)]

Hi Julien,

The root cause of this bug is quite similar to bug 1043682 comment 4 that I've mentioned the same symptom about the new line.

After testing, I've confirmed that the patch there can resolve this issue, too.

Comment 11

[Julien Wajsberg [:julienw]]

Great, I knew you were the right person to look into this ;)

Comment 12

[Francisco Jordano [:arcturus] [:francisco]]

As per discussion yesterday in IRC, we consider this not a blocker, but a nice to have in the release.
Please ask for approval-gaia-2.1 for having it uplifted.

Comment 13

[Julien Wajsberg [:julienw]]

QAWanted: please test again with a build that has the fix for bug 1043682. If it doesn't reproduce anymore, please dupe to that bug. Thanks!

Comment 14

[Pi Wei Cheng [:piwei] (inactive)]

(In reply to Julien Wajsberg [:julienw] from comment #13)
> QAWanted: please test again with a build that has the fix for bug 1043682.
> If it doesn't reproduce anymore, please dupe to that bug. Thanks!

Confirmed that the issue is no longer occurring on latest master on Flame JB base and Flame KK base.

Device: Flame
BuildID: 20140923065343
Gaia: 37b8a812c642ca616bf9457cb9b71e45261cdfa8
Gecko: 9e193395b912
Version: 35.0a1 (2.2 Master)
Firmware: v123 (Jelly Bean base)
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Device: Flame
BuildID: 20140923065343
Gaia: 37b8a812c642ca616bf9457cb9b71e45261cdfa8
Gecko: 9e193395b912
Version: 35.0a1 (2.2 Master)
Firmware: v180 (Kit Kat base)
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Josh will handle the dupe part.

Comment 15

[Joshua Mitchell (Inactive)]

Indeed