Closed Bug 1065633 Opened 10 years ago Closed 10 years ago

Intermittent test_removeVisitsByTimeframe.js | test failed (with xpcshell return code: 0) | false == true

Categories

(Toolkit :: Places, defect)

Product:
Toolkit
Component:
Places
Type:
defect
Priority:
Not set
Severity:
normal
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla35
Iteration:
35.1
Tracking Flags:
Tracking Status
firefox33 --- unaffected
firefox34 --- unaffected
firefox35 --- fixed
firefox-esr31 --- unaffected

People

(Reporter: RyanVM, Assigned: mak)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

patch v1
26.29 KB, patch
asaf
: review+
Details | Diff | Splinter Review
https://tbpl.mozilla.org/php/getParsedLog.php?id=47806165&tree=Fx-Team Rev4 MacOSX Snow Leopard 10.6 fx-team opt test xpcshell on 2014-09-10 11:38:56 PDT for push 4e2bb1833c0f slave: t-snow-r4-0048 11:56:02 INFO - TEST-INFO | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | running test ... 11:56:03 WARNING - TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | test failed (with xpcshell return code: 0), see following log: 11:56:03 INFO - >>>>>>> 11:56:03 INFO - TEST-INFO | (xpcshell/head.js) | test MAIN run_test pending (1) 11:56:03 INFO - TEST-INFO | (xpcshell/head.js) | test pending (2) 11:56:03 INFO - ***Test: Remove some visits outside valid timeframe from an unbookmarked URI 11:56:03 INFO - TEST-INFO | (xpcshell/head.js) | test pending (3) 11:56:03 INFO - TEST-INFO | (xpcshell/head.js) | test MAIN run_test finished (3) 11:56:03 INFO - TEST-INFO | (xpcshell/head.js) | running event loop 11:56:03 INFO - TEST-INFO | (xpcshell/head.js) | test finished (2) 11:56:03 INFO - Add 10 visits for the URI from way in the past. 11:56:03 INFO - Remove visits using timerange outside the URI's visits. 11:56:03 INFO - URI should still exist in moz_places. 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run : 33] 1 == true 11:56:03 INFO - Run a history query and check that all visits still exist. 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run : 42] 10 == 10 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run : 45] 1410375363359000 == 1410375363359000 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run : 45] 1410375363358999 == 1410375363358999 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run : 45] 1410375363358998 == 1410375363358998 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run : 45] 1410375363358997 == 1410375363358997 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run : 45] 1410375363358996 == 1410375363358996 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run : 45] 1410375363358995 == 1410375363358995 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run : 45] 1410375363358994 == 1410375363358994 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run : 45] 1410375363358993 == 1410375363358993 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run : 45] 1410375363358992 == 1410375363358992 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run : 45] 1410375363358991 == 1410375363358991 11:56:03 INFO - asyncHistory.isURIVisited should return true. 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run/< : 51] true == true 11:56:03 INFO - Frecency should be positive. 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run/</< : 55] true == true 11:56:03 INFO - ***Test: Remove some visits outside valid timeframe from a bookmarked URI 11:56:03 INFO - TEST-INFO | (xpcshell/head.js) | test pending (2) 11:56:03 INFO - TEST-INFO | (xpcshell/head.js) | test finished (2) 11:56:03 INFO - Add 10 visits for the URI from way in the past. 11:56:03 INFO - Bookmark the URI. 11:56:03 INFO - Remove visits using timerange outside the URI's visits. 11:56:03 INFO - URI should still exist in moz_places. 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run : 86] 1 == true 11:56:03 INFO - Run a history query and check that all visits still exist. 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run : 95] 10 == 10 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run : 98] 1410375363359000 == 1410375363359000 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run : 98] 1410375363358999 == 1410375363358999 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run : 98] 1410375363358998 == 1410375363358998 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run : 98] 1410375363358997 == 1410375363358997 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run : 98] 1410375363358996 == 1410375363358996 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run : 98] 1410375363358995 == 1410375363358995 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run : 98] 1410375363358994 == 1410375363358994 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run : 98] 1410375363358993 == 1410375363358993 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run : 98] 1410375363358992 == 1410375363358992 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run : 98] 1410375363358991 == 1410375363358991 11:56:03 INFO - asyncHistory.isURIVisited should return true. 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run/< : 104] true == true 11:56:03 INFO - Frecency should be positive. 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run/</< : 108] true == true 11:56:03 INFO - ***Test: Remove some visits from an unbookmarked URI 11:56:03 INFO - TEST-INFO | (xpcshell/head.js) | test pending (2) 11:56:03 INFO - TEST-INFO | (xpcshell/head.js) | test finished (2) 11:56:03 INFO - Add 10 visits for the URI from now to 9 usecs in the past. 11:56:03 INFO - Remove the 5 most recent visits. 11:56:03 INFO - URI should still exist in moz_places. 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run : 131] 1 == true 11:56:03 INFO - Run a history query and check that only the older 5 visits still exist. 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run : 141] 5 == 5 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run : 144] 1410375363359995 == 1410375363359995 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run : 144] 1410375363359994 == 1410375363359994 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run : 144] 1410375363359993 == 1410375363359993 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run : 144] 1410375363359992 == 1410375363359992 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run : 144] 1410375363359991 == 1410375363359991 11:56:03 INFO - asyncHistory.isURIVisited should return true. 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run/< : 150] true == true 11:56:03 INFO - Frecency should be positive. 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run/</< : 154] true == true 11:56:03 INFO - ***Test: Remove some visits from a bookmarked URI 11:56:03 INFO - TEST-INFO | (xpcshell/head.js) | test pending (2) 11:56:03 INFO - TEST-INFO | (xpcshell/head.js) | test finished (2) 11:56:03 INFO - Add 10 visits for the URI from now to 9 usecs in the past. 11:56:03 INFO - Bookmark the URI. 11:56:03 INFO - Remove the 5 most recent visits. 11:56:03 INFO - URI should still exist in moz_places. 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run : 184] 1 == true 11:56:03 INFO - Run a history query and check that only the older 5 visits still exist. 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run : 194] 5 == 5 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run : 197] 1410375363359995 == 1410375363359995 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run : 197] 1410375363359994 == 1410375363359994 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run : 197] 1410375363359993 == 1410375363359993 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run : 197] 1410375363359992 == 1410375363359992 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run : 197] 1410375363359991 == 1410375363359991 11:56:03 INFO - asyncHistory.isURIVisited should return true. 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run/< : 203] true == true 11:56:03 INFO - Frecency should be positive. 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run/</< : 207] true == true 11:56:03 INFO - ***Test: Remove all visits from an unbookmarked URI 11:56:03 INFO - TEST-INFO | (xpcshell/head.js) | test pending (2) 11:56:03 INFO - TEST-INFO | (xpcshell/head.js) | test finished (2) 11:56:03 INFO - Add some visits for the URI. 11:56:03 INFO - Remove all visits. 11:56:03 INFO - URI should no longer exist in moz_places. 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run : 230] true == true 11:56:03 INFO - Run a history query and check that no visits exist. 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run : 239] 0 == 0 11:56:03 INFO - asyncHistory.isURIVisited should return false. 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run/< : 244] true == true 11:56:03 INFO - ***Test: Remove all visits from an unbookmarked place: URI 11:56:03 INFO - TEST-INFO | (xpcshell/head.js) | test pending (2) 11:56:03 INFO - TEST-INFO | (xpcshell/head.js) | test finished (2) 11:56:03 INFO - Add some visits for the URI. 11:56:03 INFO - Remove all visits. 11:56:03 INFO - URI should still exist in moz_places. 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run : 266] 1 == true 11:56:03 INFO - Run a history query and check that no visits exist. 11:56:03 INFO - TEST-PASS | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | [tests<.continue_run : 275] 0 == 0 11:56:03 INFO - asyncHistory.isURIVisited should return false. 11:56:03 WARNING - TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js | false == true - See following stack: 11:56:03 INFO - /builds/slave/talos-slave/test/build/tests/xpcshell/tests/toolkit/components/places/tests/unit/test_removeVisitsByTimeframe.js:tests<.continue_run/<:280 11:56:03 INFO - /builds/slave/talos-slave/test/build/tests/xpcshell/head.js:_do_main:191 11:56:03 INFO - /builds/slave/talos-slave/test/build/tests/xpcshell/head.js:_execute_test:405 11:56:03 INFO - -e:null:1 11:56:03 INFO - null:null:0 11:56:03 INFO - TEST-INFO | (xpcshell/head.js) | exiting test 11:56:03 INFO - <<<<<<<
this is likely caused by bug 1047811, we should be able to fix it by adding some promiseAsyncUpdates() call after calls to removeVisitsByTimeframe. Or we could wait for bug 834545, but looks like this may be frequent enough.
Depends on: 1047811
I'll take a look at this, better to reduce randomness now, expecially cause we don't know when we'll convert all of the old tests to the new API.
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Points: --- → 1
Attached patch patch v1 — — Splinter Review
nothing really interesting here, mostly cleanup and indentation changes. The only behavioral change is the addition of the promiseAsyncUpdates() calls.
Attachment #8487902 - Flags: review?(mano)
Iteration: --- → 35.1
Flags: qe-verify?
Flags: firefox-backlog+
Flags: qe-verify? → qe-verify-
I think I'm going to crash-land this to stop the intermittent failure and get post-facto review on it. I'm honestly not even sure this is worth a review.
waiting for post-facto review yet https://hg.mozilla.org/integration/fx-team/rev/5da4f81fca8d
OS: Mac OS X → All
Hardware: x86_64 → All
Target Milestone: --- → mozilla35
https://hg.mozilla.org/mozilla-central/rev/5da4f81fca8d
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Attachment #8487902 - Flags: review?(mano) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: