106571 - nsXMLElement::mNameSpace wastes space for no good reason

Status: RESOLVED FIXED

(Core :: XML, defect)

Description

[Johnny Stenback (:jst)]

We waste 4 bytes per nsXMLElement and 4 bytes per DOMSlots in XUL for keeping a
pointer to a nsINameSpace structure that we can live just as well without. Patch
coming up that removes the member and also
nsIXMLContent::[G|S]etContainingNameSpace().

Comment 1

[Johnny Stenback (:jst)]

Attachment: Remove mNameSpace from nsXMLElement and from nsXULElement slots, also remove unused methods in nsXULContentUtils

Comment 2

[Johnny Stenback (:jst)]

There were four places where we used
nsIXMLContent::[G|S]etContainingNamespace(), element.lookupNamespaceURI() and
element.lookupNamespacePrefix(), neither of which are performance critical (and
the current code is pretty fast, so it's not that much worse), nsXBLService for
resolving prefixe to namespace no more than once per binding (hyatt sez the new
code is fine perf wise) and once in unused code in nsXULContentUtils, which I
removed.

Waterson, wanna r= this one? Is it ok to remove the unused code in
nsXULContentUtils?

Comment 3

[Chris Waterson]

Yes, remove it! This looks great. r= or sr=waterson

Comment 4

[Chris Waterson]

(it == all of it, unused XUL, too.)

Comment 5

[Chris Waterson]

Comment on attachment 54971 [details] [diff] [review]
Remove mNameSpace from nsXMLElement and from nsXULElement slots, also remove unused methods in nsXULContentUtils

sr=waterson

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 54971 [details] [diff] [review]
Remove mNameSpace from nsXMLElement and from nsXULElement slots, also remove unused methods in nsXULContentUtils

r=dbaron

Comment 7

[Johnny Stenback (:jst)]

Fix checked in, no more mNameSpace!