Closed Bug 1065716 Opened 9 years ago Closed 6 years ago

Move jsonparser to vm/JSONParser

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: evilpie, Assigned: evilpie)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

jsonparser
4.65 KB, patch
Waldo
: review+
Details | Diff | Splinter Review 
      No description provided.
Attached patch jsonparser — — Splinter Review 

        Attachment #8487556 -
        Flags: review?(jwalden+bmo)

        Attachment #8487556 -
        Flags: review?(jwalden+bmo) → review+

    
    

    
  
One plan that we have informally talked about a while ago is that, while we should eventually move everything from js/src/js* files into subdirs, we shouldn't just move them en masse but, rather, try to split them up into logical units of .h/.cpp files as we go.  In that way, js/src/js* is a TODO list.  The real targets here are the fatties like jsobj, jsscript, jsfun.  Perhaps you could initially only move the files that are relatively self-contained and then incrementally surgically eviscerate the remaining files?

    
  
Keywords: leave-open
OS: Linux → All
Hardware: x86_64 → All

    
  
Summary: Move all js*.{h,cpp} files into subdirectories → Move jsonparser to vm/JSONParser

    
  
Assignee: nobody → evilpies
Keywords: leave-open

    
  
Blocks: 1307756

    
  
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.