1065720 - [Loop] After user attempts to accept call with Loop, the Loop app appears in the background of the homescreen for a while

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[[:SalvadorR]]

Attachment: logcat_20140910_1545.txt

Description:
After user attempts to accept call with Loop app, the loop app will appear in homescreen background
   
Prerequisite: Have Loop available on device 
   
Repro Steps:
1) Update a Flame device to BuildID: 20140910000202
2) Download Loop app
3) With a seperate device that also has Loop, send a phone call to device being tested
4) Wait for phone call request in homescreen with device being tested
5) Observe Homescreen
  
Actual:
Loop app appears in the background of the homescreen
  
Expected: 
Loop app call request shows properly
  
Environmental Variables:
Device: Flame 2.1 (319mb)
BuildID: 20140910000202
Gaia: 79dc972d637ff5ef7667b231e93118b4ed83ba9c
Gecko: 0890010015a2
Version: 34.0a2 (2.1)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0
  
Repro frequency: 3/3
See attached: screenshot, logcat

Comment 1

[[:SalvadorR]]

Attachment: 2014-09-10-10-30-24.png

Comment 2

[[:SalvadorR]]

This issue occurs on  Flame 2.2 (319mb), Flame 2.1 (512mb), Flame 2.1 (319mb) and Open C 2.2

Actual:
Loop app appears in the background of the homescreen

Flame 2.2 (319mb)

Environmental Variables:
Device: Flame Master (319mb)
BuildID: 20140910040203
Gaia: 8e02f689b0fc39cb6ccdc22d02ed7e219c58faa7
Gecko: 152ef25e89ae
Version: 35.0a1 (Master) 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Flame 2.1 (319mb)

Environmental Variables:
Device: Flame 2.1 (319mb)
BuildID: 20140910000202 (512mb) 
Gaia: 79dc972d637ff5ef7667b231e93118b4ed83ba9c
Gecko: 0890010015a2
Version: 34.0a2 (2.1)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Open C 2.2

Environmental Variables:
Device: Open_C Master
BuildID: 20140910040203
Gaia: 8e02f689b0fc39cb6ccdc22d02ed7e219c58faa7
Gecko: 152ef25e89ae
Version: 35.0a1 (Master) 
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0
------------------------------------------------------------------------------------

This issue does not occurs on Flame 2.0 (319mb), Open C 2.1 and Open C 2.0

Expected: 
Loop app call request shows properly

Flame 2.0 (319mb)

Environmental Variables:
Device: Flame 2.0 (319mb)
BuildID: 20140910000203
Gaia: 3f4c635106c5364228782d12b1cb76b0c105b971
Gecko: 02a5b9234c13
Version: 32.0 (2.0) 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Open C 2.1

Environmental Variables:
Device: Open_C 2.1
BuildID: 20140910000202
Gaia: 79dc972d637ff5ef7667b231e93118b4ed83ba9c
Gecko: 0890010015a2
Version: 34.0a2 (2.1) 
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Open_C 2.0

Enviromental Variables:
Device: Open_C 2.0
BuildID: 20140910000203
Gaia: 3f4c635106c5364228782d12b1cb76b0c105b971
Gecko: 02a5b9234c13i
Version: 32.0 (2.0)
Firmware: P821A10v1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
---------------------------------------------------------------------
This feature is not implemented on Flame 1.4 (319mb) and Open C 1.4

Flame 1.4 (319mb)

Environmental Variables:
Device: Flame 1.4 (319mb)
BuildID: 20140910000204
Gaia: 6018a1c18f0c3eab25aac2ba3064904740591dd2
Gecko: 90e68c490bf9
Version: 30.0 (1.4) 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Open C 1.4

Environmental Variables:
Device: Open_C 1.4
BuildID: 20140910000204
Gaia: 6018a1c18f0c3eab25aac2ba3064904740591dd2
Gecko: 90e68c490bf9
Version: 30.0 (1.4) 
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Comment 3

[KTucker [:KTucker][Inactive 3/4/2016]]

[Blocking Requested - why for this release]:

This is a bad regression from 2.0 so nominating this 2.1?

Comment 4

[Chris Kreinbring [:CKreinbring]]

I was unable to repro the bug on KK Flame 2.2 and Flame 2.1.
Actual result:  When the device received a call from Loop while in the homescreen, the Loop screen showed in the background for a second before it came to the foreground.
Leaving tags for someone else to attempt.

Flame 2.2
BuildID: 20140917114258
Gaia: 72262d054ffa5d0d2b5a0033f713149281511aea
Gecko: d2c01d77b9d0
Version: 35.0a1 (2.2)
Firmware: v165
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Flame 2.1
BuildID: 20140917092802
Gaia: 987645cd189790e27ceb49497028ed32e8d00c90
Gecko: 9a8082b71c95
Platform Version: 34.0a2
Firmware Version: v165
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 5

[Jason Smith [:jsmith]]

blocking+ for being a bad regression. Pretty sure this isn't a Loop bug, as this reproduces using the same app on 2.1, but not 2.0. It might be a window mgmt bug, so moving over to that component.

Comment 6

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Bug 927862 seems to be the cause of this issue.

B2g-inbound Regression Window

Last working 
Environmental Variables:
Device: Flame 2.1
BuildID: 20140828211200
Gaia: 8d965e7182500fd1849e8eec5ae2aca35a55af22
Gecko: efb4f3f291a4
Version: 34.0a1 (2.1) 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0


First Broken 
Environmental Variables:
Device: Flame 2.1
BuildID: 20140828223200
Gaia: 6f270b9fee0c1f09863f5e1aa640937a07c7fdae
Gecko: 18ed4643a705
Version: 34.0a1 (2.1) 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Last working gaia / First broken gecko - Issue does NOT occur
Gaia: 8d965e7182500fd1849e8eec5ae2aca35a55af22
Gecko: 18ed4643a705

First broken gaia / Last working gecko - Issue DOES occur
Gaia: 6f270b9fee0c1f09863f5e1aa640937a07c7fdae
Gecko: efb4f3f291a4

Gaia Pushlog:  https://github.com/mozilla-b2g/gaia/compare/8d965e7182500fd1849e8eec5ae2aca35a55af22...6f270b9fee0c1f09863f5e1aa640937a07c7fdae

Comment 7

[Joshua Mitchell (Inactive)]

Broken by Bug 927862

Comment 8

[(inactive after 6/18) Alive Kuo [:alive]]

Who could tell me how to install this app? I cannot find it in marketplace.

Comment 9

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #8)
> Who could tell me how to install this app? I cannot find it in marketplace.

OK found https://wiki.mozilla.org/Loop/Try_Loop#Clients

But I have difficulty to repro. It still appear behind homescreen.

Qawanted for master, and v2.1 512MB behavior.

Comment 10

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #9)
> (In reply to Alive Kuo [:alive][NEEDINFO!] from comment #8)
> > Who could tell me how to install this app? I cannot find it in marketplace.
> 
> OK found https://wiki.mozilla.org/Loop/Try_Loop#Clients
> 
> But I have difficulty to repro. It still appear behind homescreen.
> 
> Qawanted for master, and v2.1 512MB behavior.

In v2.1 what I am seeing: the loop callscreen will display under homescreen "for 1 sec" but homescreen then disappear so you could accept the call. Is this what the bug talking about?

Comment 11

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Alive,
That is the bug as confirmed by the original reporter.

Comment 12

[Joshua Mitchell (Inactive)]

> In v2.1 what I am seeing: the loop callscreen will display under homescreen
> "for 1 sec" but homescreen then disappear so you could accept the call. Is
> this what the bug talking about?


Yes

Comment 13

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Joshua Mitchell [:Joshua_M] from comment #12)
> > In v2.1 what I am seeing: the loop callscreen will display under homescreen
> > "for 1 sec" but homescreen then disappear so you could accept the call. Is
> > this what the bug talking about?
> 
> 
> Yes

We need to reflect the fact in summary. Patch coming.

Comment 14

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: patch for master

The active class applying is really slow in low end device. I don't think there's something broken if we always have a high level attention window instead only active attention window.

Comment 15

[Etienne Segonzac (:etienne)]

Comment on attachment 8494397 [details] [review]
patch for master

I guess it's better this way but we should try to figure out a default transition for attentionwindows (in a separate bug).

Comment 16

[Joshua Mitchell (Inactive)]

I believe the qa-wanted questions were answered, if not, please re-add it.

Comment 17

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Etienne Segonzac (:etienne) from comment #15)
> Comment on attachment 8494397 [details] [review]
> patch for master
> 
> I guess it's better this way but we should try to figure out a default
> transition for attentionwindows (in a separate bug).

BTW I am in the opposite position - we should remove the callscreen animation :)

Comment 18

[(inactive after 6/18) Alive Kuo [:alive]]

https://github.com/mozilla-b2g/gaia/commit/d76d3876d9a240a7ccb3d786bfc649f1580657bd

Comment 19

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8494397 [details] [review]
patch for master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
Bug 927862
[User impact] if declined:
The user of the low-end device will notice the attention window under current active app before the active app disappear.
[Testing completed]:
tbpl is green
[Risk to taking this patch] (and alternatives if risky):
riskless - one line css change
[String changes made]:
NO

Comment 20

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/f6c96ea44ef1c772169336271a1eb9d03426a5e0

Comment 21

[sarsenyev]

Verified the issue is fixed on 2.2 and 2.1
The Loop's incoming call doesn't appear on background

"Flame 2.2

Device: Flame 2.2 (319mb)(Kitkat Base)(Shallow Flash)
BuildID: 20141119040205
Gaia: e64428c5b2dce5db90b75a5055077a04f4bd4819
Gecko: bc2c36dda0a9
Version: 36.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0"

"Flame 2.1 

Device: Flame 2.1 (319mb)(Kitkat Base)(Shallow Flash)
Build ID: 20141119001205
Gaia: 1b231b87aad384842dfc79614b2a9ca68a4b4ff3
Gecko: 95fbd7635152
Version: 34.0 (2.1)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0"

Comment 22

[chinachin]

I agree, I look forward to another such great article. Thank you!
https://wordcounter.tools