1065905 - WARNING: Should be playing: 'mPlaying', file ../../../gecko/content/media/AudioSink.cpp, line 303

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

Found this bug while testing media tests on B2G emulator debug.

https://tbpl.mozilla.org/php/getParsedLog.php?id=47848925&tree=Try&full=1
21:25:55     INFO -  [Child 767] WARNING: Should be playing: 'mPlaying', file ../../../gecko/content/media/AudioSink.cpp, line 303

file: https://hg.mozilla.org/try/file/7a883a65dad9/content/media/AudioSink.cpp#l303

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1065905_fix_mPlaying_in_AudioSink-v1.patch

Remove warning on |mPlaying| for it could change when AudioSink not in the monitor.

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8489212 [details] [diff] [review]
1065905_fix_mPlaying_in_AudioSink-v1.patch

Review of attachment 8489212 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/AudioSink.cpp
@@ -298,5 @@
> -    ReentrantMonitorAutoEnter mon(GetReentrantMonitor());
> -    NS_WARN_IF_FALSE(mPlaying, "Should be playing");
> -    // Awaken the decode loop if it's waiting for space to free up in the
> -    // audio queue.
> -    GetReentrantMonitor().NotifyAll();

Remove notification for it is already handled by the pop listener.
http://hg.mozilla.org/mozilla-central/file/bf5fcc0c4b27/content/media/MediaDecoderStateMachine.cpp#l1947

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8489212 [details] [diff] [review]
1065905_fix_mPlaying_in_AudioSink-v1.patch

Try: https://tbpl.mozilla.org/?tree=Try&rev=10a73aec1d8b
Most green.

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/01ccf9bdf3d2

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/01ccf9bdf3d2