1065908 - Incorrect position of buttons in export/import options

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Comment 1

[Jose Manuel Cantera]

Import / Export button options on Contact Settings are incorrectly placed as they don't have the correct margins

Comment 2

[Jose Manuel Cantera]

Attachment: 23942.html

Comment 3

[Fang Shih [:fang]]

Comment on attachment 8487765 [details]
23942.html

It looks great! Thanks!

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8487765 [details]
23942.html

Tested on the phone and looking good :)

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8487765 [details]
23942.html

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
Contacts edit form redesign
[User impact] if declined:
Bad user experience (look attachments)
[Testing completed]:
Smoke test passed
[Risk to taking this patch] (and alternatives if risky):
Pretty low, just css rules
[String changes made]:

Comment 6

[Jose Manuel Cantera]

Attachment: incorrect position

Comment 7

[Jose Manuel Cantera]

Attachment: incorrect position 2

Comment 8

[Jose Manuel Cantera]

landed in master:

https://github.com/mozilla-b2g/gaia/commit/4c69ac55297da277c0426e8c10f02409268c8fbc

Comment 9

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/1a2a559a4801b0aeae875183cd03121b26480dd2

Comment 10

[Alissa（leave from Mozilla）]

Attachment: verify.png

This issue has been successfully verified on Flame 2.1, 2.2
See attachment:verify.png
Reproducing rate: 0/5

Flame 2.1 new build:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141202001201
Version         34.0
Flame 2.2 version:
Gaia-Rev        725685831f5336cf007e36d9a812aad689604695
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/2c9781c3e9b5
Build-ID        20141202040207
Version         37.0a1