Closed Bug 1065908 Opened 9 years ago Closed 9 years ago

Incorrect position of buttons in export/import options

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Contacts
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.0 unaffected, b2g-v2.1 verified, b2g-v2.2 verified)

Status:
VERIFIED FIXED
Milestone:
2.1 S4 (12sep)
Tracking Flags:
Tracking Status
b2g-v2.0 --- unaffected
b2g-v2.1 --- verified
b2g-v2.2 --- verified

People

(Reporter: jmcf, Assigned: jmcf)

Details

Attachments

(4 files)

23942.html
191 bytes, text/html
arcturus
: review+
fang
: ui-review+
bajaj
: approval-gaia-v2.1+
Details
incorrect position
37.97 KB, image/png
Details
incorrect position 2
27.38 KB, image/png
Details
verify.png
36.69 KB, image/png
Details 
      No description provided.
Import / Export button options on Contact Settings are incorrectly placed as they don't have the correct margins
Attached file 23942.html — 

        Attachment #8487765 -
        Flags: ui-review?(fshih)

        Attachment #8487765 -
        Flags: review?(francisco)

    
    

    
  
Comment on attachment 8487765 [details]
23942.html

It looks great! Thanks!

    
  

        Attachment #8487765 -
        Flags: ui-review?(fshih) → ui-review+

    
    

    
  
Comment on attachment 8487765 [details]
23942.html

Tested on the phone and looking good :)

        Attachment #8487765 -
        Flags: review?(francisco) → review+

    
    

    
  
Comment on attachment 8487765 [details]
23942.html

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
Contacts edit form redesign
[User impact] if declined:
Bad user experience (look attachments)
[Testing completed]:
Smoke test passed
[Risk to taking this patch] (and alternatives if risky):
Pretty low, just css rules
[String changes made]:

        Attachment #8487765 -
        Flags: approval-gaia-v2.1?(bbajaj)

    
    

    
  

      
      
      
      

        Attached image
          
        incorrect position
        — 
      

    


  

    
    

    
  

      
      
      
      

        Attached image
          
        incorrect position 2
        — 
      

    


  

    
    

    
  
landed in master:

https://github.com/mozilla-b2g/gaia/commit/4c69ac55297da277c0426e8c10f02409268c8fbc
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED

          status-b2g-v2.2:
          affected → fixed
Target Milestone: --- → 2.1 S4 (12sep)

        Attachment #8487765 -
        Flags: approval-gaia-v2.1?(bbajaj) → approval-gaia-v2.1+

    
    

    
  

      
      
      
      

        Attached image
          
        verify.png
        — 
      

    


  
This issue has been successfully verified on Flame 2.1, 2.2
See attachment:verify.png
Reproducing rate: 0/5

Flame 2.1 new build:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141202001201
Version         34.0
Flame 2.2 version:
Gaia-Rev        725685831f5336cf007e36d9a812aad689604695
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/2c9781c3e9b5
Build-ID        20141202040207
Version         37.0a1
Status: RESOLVED → VERIFIED

          status-b2g-v2.1:
          fixed → verified

          status-b2g-v2.2:
          fixed → verified

          You need to log in
          before you can comment on or make changes to this bug.