1065923 - Simplify TelemetryVFS by removing telemetry gathering and rename it BaseVFS

Status: RESOLVED FIXED

(Toolkit :: Storage, defect, P3)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Most of the telemetry is reporting useless or not measurable stuff, and thus many probes will just expire in version 40.

We should simplify this code and eventually evaluate to rename it to quotaVFS or storageVFS since telemetry won't be anymore the primary purpose of it.

See the various probes:
- MOZ_SQLITE_*
- MOZ_STORAGE_*

Comment 1

[Jan Varga [:janv]]

Sounds good to me. I would prefer QuotaVFS.

Comment 2

[Marion Daly [:mdaly]]

Andrew: would it be okay if we move this to backlog? DWS_NEXT perhaps?

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

Yeah, I thought I'd already removed myself from this (probably in an open tab somewhere), but this is probably a good medium-term cleanup as far as QuotaManager is concerned (after WSIF).

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: Bug 1065923 - Rename Storage TelemetryVFS to BaseVFS. r=janv

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: Bug 1065923 - Remove histograms from Storage BaseVFS. r=Mossop!,janv

As previously discussed, we're not using this telemetry at the moment, we used
it in the past to study main thread IO.
Simplifying the VFS allows us to more easily experiment with other settings
in the future.

Depends on D172015

Comment 6

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

This is not going to land before the merge.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a32ebe969fa8
Rename Storage TelemetryVFS to BaseVFS. r=janv
https://hg.mozilla.org/integration/autoland/rev/656d0aa7e02c
Remove histograms from Storage BaseVFS. r=janv,mossop,dom-storage-reviewers

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/a32ebe969fa8
https://hg.mozilla.org/mozilla-central/rev/656d0aa7e02c