1065926 - Set expiration to never for these Places probes

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Marco Bonardo [:mak]]

FX_BOOKMARKS_TOOLBAR_INIT_MS should not have been set to expire: 40, per https://bugzilla.mozilla.org/show_bug.cgi?id=1045108#c53

I forgot to comment about PLACES_AUTOCOMPLETE_URLINLINE_DOMAIN_QUERY_TIME_MS, it should also not expire.

Comment 1

[Ayush Mishra]

Please assign this bug to me. I am a begginer, so please help me and tell about the bug.

Comment 2

[Marco Bonardo [:mak]]

Hello, do you already have a working build?
See https://developer.mozilla.org/en-US/docs/Introduction

The bug here is simple, in toolkit/components/telemetry/Histograms.json the 2 probes indicated in comment 0 are set to expire at version "40", instead they should be set to expire "never"

We assign the bugs when the first patch is attached, no worries.

Comment 3

[Ayush Mishra]

Attachment: Patch for this bug.

Attached the patch.

Comment 4

[Marco Bonardo [:mak]]

Comment on attachment 8488012 [details] [diff] [review]
Patch for this bug.

Review of attachment 8488012 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you, when attaching a patch you should usually (if it's ready) ask for review to someone, usually the mentor is fine, bugzilla can also suggest a good reviewer if you don't know.
You may also ask for feedback if the patch is not ready to be landed but you need feedback.

Btw, the patch looks good, as well as the commit message.
A small not important thing is that we usually use the irc nicknames for reviews, so in this case would be r=mak rather than full name.

Now that the patch has review it should be landed. Since you don't have access you can ask for someone else to land it for you. In the most common case it should be pushed to the Try Server to check it is passing all of the tests (you could do that with commit access level 1, or the mentor can do that for you in case you're missing the access level. See https://www.mozilla.org/hacking/commit-access-policy/)

In this case the patch has no risks so I'll directly ask for someone to push it to the tree.

Thank you for your contribution!

Comment 5

[Marco Bonardo [:mak]]

Note for the sheriffs: I'm not pushing this to Try cause the possibility of causing failures is basically nonexistent. Would also be fine to DONTBUILD it.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/72a4631bcb58

Comment 7

[Ayush Mishra]

Ohh. What should I do next to get the bug status resolved?

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/72a4631bcb58

Comment 9

[Marco Bonardo [:mak]]

(In reply to Ayush Mishra from comment #7)
> Ohh. What should I do next to get the bug status resolved?

nothing, it gets resolved when the landing branch is merged to Mozilla-Central.