1065965 - When disabled, saving buttons (regular editing UI + in CKEditor) must have a clear "disabled" look.

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Editing, defect)

Description

[Jean-Yves Perrier [:teoli]]

I'm really happy with the disabling of the saving buttons.

I unexpectedly hit the case earlier today, and it took me a while to figure that if the saving wasn't working it was because I clicked disabled buttons.

The four buttons (2 on the regular UI, 2 in CKeditor) should be dimmed to mark their disabled state and the hover tooltip should indicate why (no change since last save).

We are close! :-)

Comment 1

[Luke Crouch [:groovecoder]]

cc Ruben ; mentor: David

Comment 2

[David Walsh :davidwalsh]

Thank you so much for your help so far Ruben!  You're 90% of the way there, we just need to tidy this last piece up!

Here's where we create those buttons for the editor:
https://github.com/mozilla/kuma/blob/master/media/js/libs/ckeditor/plugins/mdn-buttons/plugin.js#L78

And here's the button API for CKEditor:
https://github.com/mozilla/kuma/blob/master/media/js/libs/ckeditor/_source/plugins/button/plugin.js#L247

You'll need to call `setState` on those buttons upon clean/dirty, much like you do now.  It looks like disabling is `CKEDITOR.TRISTATE_DISABLED` and re-enabling is `TRISTATE_ON`.

Let me know if I can help more!

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/f3b66c0ed4826b68017f166de79548229c0209e0
bug 1065965 - Make disabled buttons less visible

https://github.com/mozilla/kuma/commit/fa3b5248b2010d4268247e1f16a23e533a084727
Merge pull request #2743 from darkwing/1065965-disabled-buttons

bug 1065965 - Make disabled buttons less visible

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/501d0bfb1ff3c917773e95fe3489c7edd3e66d53
fix bug 1065965 - When disabled, saving buttons must have a clear "disabled" look

CKEditor buttons are now enabled/disabled appropriately.

https://github.com/mozilla/kuma/commit/c8e143e0706acf2233c6ec6c3088508c79a380bf
Merge pull request #2744 from rubenvereecken/new-issue-1065965

fix bug 1065965 - When disabled, CKEditor saving buttons must have a clear disabled look

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/47e485f0b3816c81ad605599e288e50ea08692c5
bug 1065965 - Ensure save buttons enable when CKEditor source is edited.

https://github.com/mozilla/kuma/commit/a77f9485e0d00301b2e248d567370b338e9c9028
Merge pull request #2804 from darkwing/fix-source-ckeditor

bug 1065965 - Ensure save buttons enable when CKEditor source is edited.