1066013 - Initialize appCache path

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[Zoran Jovanovic]

Attachment: 0001-Initialize-appCache-path.patch

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/36.0.1985.125 Safari/537.36

Steps to reproduce:

Preload appcache for apps pre-installed to /data partition in FFOS, e.g. with eng build of FFOS.


Actual results:

appCache path on app object not initialized resulting in failed cache installation.


Expected results:

Cache should be installed and apps should load offline.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Sadly I don't know this code.

Comment 2

[Honza Bambas (:mayhemer)]

Me neither.

Comment 3

[[:fabrice] Fabrice Desré]

We used to set cachePath in gaia's build system when creating the webapps.json file that ends up in /system. Your patch will add an appCache property to all apps even if they don't need it, and so we don't bail out early in OfflineCacheInstaller.installCache() anymore (we exit at !cacheDir.exists() though so it's not too terrible either).

I think we should rather fix updateOfflineCacheForApp() to check if manifest.fullAppcachePath() exists, and if so call OfflineCacheInstaller.installCache({ cachePath: app.cachePath || app.basePath, ... });

Comment 4

[Zoran Jovanovic]

Attachment: Bug_1066013-Start-cache-update-only-if-cache-exists.patch

Fixes Fabrice's comments.

Comment 5

[Francis Lee [:frlee]]

[Blocking Requested - why for this release]:

partner would like to have this fix in 2.1, raise 2.1? for triage.

Comment 6

[bhavana bajaj [:bajaj]]

fabrice, can you please uplift if its low risk ?

Comment 7

[Francis Lee [:frlee]]

hi Bhavana,

since both review+ and uplift approval granted, could you please let me know when it will be uplifted to 2.1?

Comment 8

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/b2g-inbound/rev/05c387c9464f

Comment 9

[[:fabrice] Fabrice Desré]

(In reply to Francis Lee [:frlee] from comment #7)
> hi Bhavana,
> 
> since both review+ and uplift approval granted, could you please let me know
> when it will be uplifted to 2.1?

The patch was not even landed... People need to do diligence to ensure their work ends up in the tree.

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/05c387c9464f

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/104ff03a3ec1