1066024 - Some high-DPI assets in GaiaGrid are incorrectly named

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Components, defect)

Description

[Chris Lord [:cwiiis]]

[Blocking Requested - why for this release]: (see below)

High-DPI assets for shared components seem to all get bundled, instead of the correct one renamed during build.

This can be seen if you look inside, say, the vertical home webapp zip and look at the images in the shared grid component - all of the suffixed images are bundled instead of just one at the correct resolution.

This is mirrored in the app, where the unprefixed, low-dpi image will always be shown.

Nominating this to block 2.1, as there are a number of high-dpi assets in shared components and this will not only make apps look worse than they should, but make them significantly larger too. I assume it's too late for 2.0(?)

Comment 1

[Chris Lord [:cwiiis]]

[Blocking Requested - why for this release]: Didn't realise things could still block 2.0.

I think this is critical enough that it should block 2.0 as it will make high-dpi devices look worse, but more critically, it will significantly increase the size of bundled apps (which is bad news for storage-limited devices).

Comment 2

[Chris Lord [:cwiiis]]

urk, the bug isn't in the build system, the assets are missing the 'x' part of the suffix. This should probably still block, but probably doesn't affect quite as much thankfully :)

Comment 3

[Chris Lord [:cwiiis]]

I'll take this, this is just a simple renaming.

Comment 4

[Chris Lord [:cwiiis]]

Attachment: Rename hi-dpi assets

Doesn't hurt to get a look over this.

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8487888 [details] [review]
Rename hi-dpi assets

Doh, nice find! This makes me sad. Seems like we might want a linter for this.

Comment 6

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/cb3464536a163aa14fceb90fa821c1eb20b7a7c9

Comment 7

[Chris Lord [:cwiiis]]

Comment on attachment 8487888 [details] [review]
Rename hi-dpi assets

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Apps that use GaiaGrid may have some fuzzy icons and a larger app zip than necessary
[User impact] if declined: Fuzzy icons and less on-board storage for the system
[Testing completed]: Tested locally
[Risk to taking this patch] (and alternatives if risky): Low risk, just a rename
[String changes made]: None

Comment 8

[bhavana bajaj [:bajaj]]

Triage did not block on this as this does not appear to be a regression or has high impact to consider blocking, so this nice fix could get in 2.1 via approval given we are still taking low risk fixes there.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/b099878ed64ff0240d59783485d73f374b6b5931