Closed
Bug 1066123
Opened 9 years ago
Closed 9 years ago
Fix b2g desktop osx due to v2 signature changes for Firefox.app
Categories
(Firefox OS Graveyard :: Emulator, defect)
Tracking
(firefox34 fixed, firefox35 fixed)
RESOLVED
FIXED
People
(Reporter: spohl, Assigned: spohl)
References
Details
Attachments
(1 file, 2 obsolete files)
3.13 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
Although the file structure for Firefox.app has changed to support v2 signatures on OSX, the structure for b2g desktop OSX bundles hasn't changed (yet). We need to ensure that packager.mk continues to do the right thing for b2g desktop OSX builds.
Assignee | ||
Comment 1•9 years ago
|
||
Will send to try shortly to confirm.
Assignee | ||
Comment 2•9 years ago
|
||
Turns out that this will need significantly more work, and a package layout like the Firefox.app after all. Looking into it.
Summary: Ensure that packager.mk does the right thing for b2g desktop OSX after the v2 changes to Firefox OSX bundles → Fix b2g desktop osx due to v2 signature changes for Firefox.app
Assignee | ||
Comment 3•9 years ago
|
||
Try run: https://tbpl.mozilla.org/?tree=Try&rev=035a5f84f3cf
Attachment #8487966 -
Attachment is obsolete: true
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8488390 [details] [diff] [review] Patch Try turned green.
Attachment #8488390 -
Flags: review?(ted)
![]() |
||
Comment 5•9 years ago
|
||
Comment on attachment 8488390 [details] [diff] [review] Patch >diff --git a/b2g/installer/package-manifest.in b/b2g/installer/package-manifest.in >--- a/b2g/installer/package-manifest.in >+++ b/b2g/installer/package-manifest.in >@@ -37,17 +37,16 @@ > #endif > @BINPATH@/dictionaries/* > @BINPATH@/hyphenation/* > #ifdef XP_WIN32 > @BINPATH@/uninstall/helper.exe > #endif > > [xpcom] >-@BINPATH@/dependentlibs.list removing this will break other builds
Assignee | ||
Comment 6•9 years ago
|
||
True, that should probably have been ifdef'd to OSX. Will look into it. Which builds failed?
Assignee | ||
Comment 7•9 years ago
|
||
Attachment #8488390 -
Attachment is obsolete: true
Attachment #8488390 -
Flags: review?(ted)
Assignee | ||
Comment 8•9 years ago
|
||
Comment on attachment 8489019 [details] [diff] [review] Patch Try run is green (updater xpcshell test failures are handled in separate bugs): https://tbpl.mozilla.org/?tree=Try&rev=3b9892dd2636
Attachment #8489019 -
Flags: review?(ted)
![]() |
||
Comment 9•9 years ago
|
||
(In reply to Stephen Pohl [:spohl] from comment #6) > True, that should probably have been ifdef'd to OSX. Will look into it. > > Which builds failed? The build would succeed but running the build or tests would fail since that file is needed. B2G ICS Emulator Opt was failing tests for me. Thanks!
Assignee | ||
Comment 10•9 years ago
|
||
https://hg.mozilla.org/projects/oak/rev/9ccc94badb84
Updated•9 years ago
|
Attachment #8489019 -
Flags: review?(ted) → review+
![]() |
||
Comment 11•9 years ago
|
||
Pushed to fx-team https://hg.mozilla.org/integration/fx-team/rev/47c2f60b1174
Comment 12•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/47c2f60b1174
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
![]() |
||
Comment 13•8 years ago
|
||
Landed on aurora in the Mac V2 signing combined patch in bug 1047584
status-firefox34:
--- → fixed
status-firefox35:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•