Closed Bug 1066123 Opened 5 years ago Closed 5 years ago

Fix b2g desktop osx due to v2 signature changes for Firefox.app

Categories

(Firefox OS Graveyard :: Emulator, defect)

Product:
Firefox OS Graveyard
Component:
Emulator
Platform:
All
macOS
Type:
defect
Priority:
Not set

Tracking

(firefox34 fixed, firefox35 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox34 --- fixed
firefox35 --- fixed

People

(Reporter: spohl, Assigned: spohl)

References

Details

Attachments

(1 file, 2 obsolete files)

Patch
3.13 KB, patch
ted
: review+
Details | Diff | Splinter Review 
Although the file structure for Firefox.app has changed to support v2 signatures on OSX, the structure for b2g desktop OSX bundles hasn't changed (yet). We need to ensure that packager.mk continues to do the right thing for b2g desktop OSX builds.
Attached patch Patch (obsolete) — — Splinter Review 
Will send to try shortly to confirm.
Turns out that this will need significantly more work, and a package layout like the Firefox.app after all. Looking into it.
Summary: Ensure that packager.mk does the right thing for b2g desktop OSX after the v2 changes to Firefox OSX bundles → Fix b2g desktop osx due to v2 signature changes for Firefox.app
Attached patch Patch (obsolete) — — Splinter Review 
Try run:
https://tbpl.mozilla.org/?tree=Try&rev=035a5f84f3cf
Attachment #8487966 - Attachment is obsolete: true
Comment on attachment 8488390 [details] [diff] [review]
Patch

Try turned green.
Attachment #8488390 - Flags: review?(ted)
Comment on attachment 8488390 [details] [diff] [review]
Patch

>diff --git a/b2g/installer/package-manifest.in b/b2g/installer/package-manifest.in
>--- a/b2g/installer/package-manifest.in
>+++ b/b2g/installer/package-manifest.in
>@@ -37,17 +37,16 @@
> #endif
> @BINPATH@/dictionaries/*
> @BINPATH@/hyphenation/*
> #ifdef XP_WIN32
> @BINPATH@/uninstall/helper.exe
> #endif
> 
> [xpcom]
>-@BINPATH@/dependentlibs.list
removing this will break other builds
True, that should probably have been ifdef'd to OSX. Will look into it.

Which builds failed?
Attached patch Patch — — Splinter Review
Attachment #8488390 - Attachment is obsolete: true
Attachment #8488390 - Flags: review?(ted)
Comment on attachment 8489019 [details] [diff] [review]
Patch

Try run is green (updater xpcshell test failures are handled in separate bugs):
https://tbpl.mozilla.org/?tree=Try&rev=3b9892dd2636
Attachment #8489019 - Flags: review?(ted)
(In reply to Stephen Pohl [:spohl] from comment #6)
> True, that should probably have been ifdef'd to OSX. Will look into it.
> 
> Which builds failed?
The build would succeed but running the build or tests would fail since that file is needed.
B2G ICS Emulator Opt was failing tests for me.

Thanks!
Attachment #8489019 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/47c2f60b1174
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Landed on aurora in the Mac V2 signing combined patch in bug 1047584
status-firefox34: --- → fixed
status-firefox35: --- → fixed
You need to log in before you can comment on or make changes to this bug.