1066141 - about:support mistakenly shows presence of user.js in Firefox for Android

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[[:philipp]]

if you go to about:support on firefox on android, the page mistakenly shows the presence of a user.js file - when you manually go to the profile folder on a rooted device though the file isn't actually there...

only a minor glitch

Comment 1

[travneff]

Seems still actual for FF38 for Android

Comment 2

[Rob Wu [:robwu]]

Attachment: Bug 1066141 - Consistently hide about:support sections

Some elements were shown when they should not be on Android,
because these elements rely on the hidden class name introduced in bug
948883, but that declaration is missing for the mobile-specific
aboutSupport.css style sheet.

This patch fixes the visibility by relying on the hidden attribute
instead, and for consistency replaces all uses of display:none with
the hidden boolean. I verified that there are no display rules in
either aboutSupport.css file that would supersede the display:none
declaration of the [hidden] attribute.

Moreover, to avoid errors about "content-analysis-active" element that
is non-existent on Android due to ifndef in the XHTML file, an early
return is added to its usage.
I also audited all uses of ifndef in the aboutSupport.xhtml file and
added/changed the condition in the aboutSupport.js file for consistency.

Comment 3

[Rob Wu [:robwu]]

Comment 2 references two bugs:

• This reported regression was introduced in bug 948883.
• "content-analysis-active" error / logspam was introduced in bug 1882606.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d9d6cf319134
https://hg.mozilla.org/integration/autoland/rev/aaac5b368ca0
Consistently hide about:support sections r=desktop-theme-reviewers,emilio

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7168886aaec5
https://hg.mozilla.org/integration/autoland/rev/c53fb03c32b2
Revert "Bug 1066141 - Consistently hide about:support sections r=desktop-theme-reviewers,emilio" for causing bc failures @ browser_aboutSupport_places.js

Comment 6

[amarc]

Backed out for causing bc failures @ browser_aboutSupport_places

• Backout link
• Push with failures
• Failure Log

Comment 7

[Rob Wu [:robwu]]

The test explicitly checked inline style.display states, but because the patch refactored to use the hidden attribute, that does not work.

I've switched to ContentTaskUtils.isHidden and isVisible, and the test now passes again.

As an extra sanity check I looked for all tests that reference "about:support" and ran them locally, they all pass.

So I'll reland the patch with the fix.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a11a8ea59884
https://hg.mozilla.org/integration/autoland/rev/9b01093af974
Consistently hide about:support sections r=desktop-theme-reviewers,emilio

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/9b01093af974