1066155 - Feedback message containing only blank spaces can be sent

Status: VERIFIED FIXED

(Marketplace Graveyard :: API, defect, P3)

Description

[Madalin Cotetiu]

Steps to reproduce:
1. Open marketplace homepage and login https://marketplace-dev.allizom.org/
2. Hover over the gear icon and click on Feedback
3. Press the space bar to enter some blank spaces
4. Click the Send button

Expected results:
An error message is displayed stating that invalid characters are introduced or that the feedback message is invalid.

Actual results:
The empty feedback message is displayed.

Notes/Issues:
The same issue reproduce in Report Abuse form.
Verified in FF35(Win7) Issue is reproducing in -dev, stage and production.
Screencast for this issue: http://screencast.com/t/jnl6xCyT18

Comment 1

[Christopher Van Wiemeersch [:cvan]]

This should be fixed in Fireplace (the `textarea` field) and Zamboni (the API endpoint).

We fixed this for the Display Name by adding a pattern that disallows an input value of entirely whitespace characters:

    pattern="[^\s].*|\s+\S.+"

See here:

    https://github.com/mozilla/fireplace/blob/70f8066/src/templates/settings/main.html#L23

Comment 2

[Lavish Aggarwal]

Attachment: patch to avoid feedbacks having only white spaces

PR : https://github.com/mozilla/zamboni/pull/3273/

travis build passed.

Please verify.

Comment 3

[Lavish Aggarwal]

Attachment: code refactored

PR : https://github.com/mozilla/zamboni/pull/3273

Please verify

Comment 4

[Mathieu Pillard [:mat]]

Fixed in the API side in https://github.com/mozilla/zamboni/commit/f251df3e1e08354488296066ed2e06ce998f7f77

Comment 5

[Madalin Cotetiu]

I think that the Submit Feedback button should be inactive if empty string is added. Now we are returning an error message when an empty string is submitted, which is confusing.
http://screencast.com/t/zyYm9Lnro

Reopening.

Comment 6

[Mathieu Pillard [:mat]]

Madalin: please open a new bug in consumer pages for this. The API behaves correctly now.

Comment 7

[Madalin Cotetiu]

Mathieu you are right the API is working correctly.
I have filled Bug 1197203 for the front end part.
Closing this bug.