Closed
Bug 1066248
Opened 10 years ago
Closed 10 years ago
Show "[0]" in the title when there are no failures in the current view
Categories
(Tree Management :: Treeherder, defect, P3)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: botond, Assigned: emorley)
Details
Attachments
(1 file)
1.11 KB,
patch
|
camd
:
review+
|
Details | Diff | Splinter Review |
I just did a Try push, and I'm looking at it in both TBPL [1] and Treeherder [2]. In TBPL, the page title is "[0] Bug 1065008 - Consider the shadow transform when computing the opaq... - Try - TBPL". In Treeherder, the page title is "try". The "[0]" in the TBPL title is the number of non-starred problems. Having this in the title bar allows me to keep an eye on how the Try push is going without having the tab active. Treeherder should include this number in the title too, as well as match the TBPL title's informativeness in other ways (e.g. showing "Bug 1065008 - Consider..." instead of "try"). [1] https://tbpl.mozilla.org/?tree=Try&rev=941628a8b5cb [2] https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=941628a8b5cb
Reporter | ||
Comment 1•10 years ago
|
||
I just had a "[1]" appear at the beginning of the Treeherder title, so I guess the absence of a number was supposed to mean "[0]". That resolves my main concern. I'll leave the bug open for the other thing (showing the commit message of the commit you're testing, rather than "try", in the title).
Summary: Treeherder page title should show number of non-starred problems → Improve Treeherder page title
The second part's already covered in bug 1045602.
Summary: Improve Treeherder page title → Show "[0]" in the title when there are no failures in the current view
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → emorley
Status: NEW → ASSIGNED
OS: Linux → All
Priority: -- → P3
Hardware: x86_64 → All
Updated•10 years ago
|
Attachment #8488273 -
Flags: review?(cdawson) → review+
Comment 4•10 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder-ui https://github.com/mozilla/treeherder-ui/commit/d8545a6e5c63318825494cf75f8b0c33f3106241 Bug 1066248 - Always show the unclassified failure count in the tab title
Assignee | ||
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 5•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/627fc2e1b730c114e634d29f9fe66654ba52d9ce Bug 1066248 - Always show the unclassified failure count in the tab title
You need to log in
before you can comment on or make changes to this bug.
Description
•