1066322 - Enable ES6 symbols in all builds

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[Jason Orendorff [:jorendorff]]

Morphing this bug. Now it's about enabling symbols in all builds. But we'll leave the old code and the JS_HAS_SYMBOLS switch in place, in case problems turn up in Aurora or Beta and it needs to be disabled.

Bug 1069416 is about killing the #ifdefs etc. (once we're shipping symbols).

Comment 2

[Jason Orendorff [:jorendorff]]

Attachment: Enable ES6 symbols in all builds

Comment 3

[Jason Orendorff [:jorendorff]]

Let's ship this.

I know Jeff would rather let it bake another cycle or two, but the fuzzers have been quiet for a long time now. And leaving it disabled also has costs and risks. Having tests break when we go to Aurora (due to the change in behavior caused by #ifdef NIGHTLY_ONLY) is a burden, writing "if (typeof Symbol...)" in every test in the first place is a burden, and there's work like bug 1054756 that's blocked on shipping this.

Comment 4

[Jan de Mooij [:jandem]]

Comment on attachment 8517269 [details] [diff] [review]
Enable ES6 symbols in all builds

Review of attachment 8517269 [details] [diff] [review]:
-----------------------------------------------------------------

\o/ Nightly-only for 4 release cycles is certainly enough IMO.

Comment 5

[Jan de Mooij [:jandem]]

Btw, a blog post would be great. People love to know what we're doing, what's next etc.

(Or maybe an "ES6 status" post so that we can also mention some smaller features and stuff we're working on right now.)

Comment 6

[Jason Orendorff [:jorendorff]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2077002427eb

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2077002427eb

Comment 8

[Florian Scholz (Open Web Docs)]

(In reply to Jan de Mooij [:jandem] from comment #5)
> Btw, a blog post would be great. People love to know what we're doing,
> what's next etc.
> 
> (Or maybe an "ES6 status" post so that we can also mention some smaller
> features and stuff we're working on right now.)

See also https://developer.mozilla.org/en-US/docs/Web/JavaScript/New_in_JavaScript/ECMAScript_6_support_in_Mozilla for inspiration.


For Symbols, I made sure to update Fx versions in the docs I posted in bug 645416 comment 169 to Fx36.

Firefox 36 for developers mentions Symbol now, too:
https://developer.mozilla.org/en-US/Firefox/Releases/36#JavaScript


Setting again relnote?, because this only made it to Aurora relnotes until now, I think.

Release Note Request (optional, but appreciated)
[Why is this notable]: More ES6 enabled, see bug 645416 comment 170 were we had this already.
[Suggested wording]:"Support for the ECMAScript 6 Symbol data type added (learn more)"
[Links (documentation, blog post, etc)]:
Learn more pointing to: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Symbol