Enable ES6 symbols in all builds

RESOLVED FIXED in mozilla36

Status

()

Core
JavaScript Engine
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: jorendorff, Assigned: jorendorff)

Tracking

(Blocks: 1 bug, {dev-doc-complete})

unspecified
mozilla36
x86_64
Linux
dev-doc-complete
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(relnote-firefox 36+)

Details

(Whiteboard: [DocArea=JS])

Attachments

(1 attachment)

Comment hidden (empty)
Keywords: dev-doc-needed
Whiteboard: [DocArea=JS]
(Assignee)

Comment 1

3 years ago
Morphing this bug. Now it's about enabling symbols in all builds. But we'll leave the old code and the JS_HAS_SYMBOLS switch in place, in case problems turn up in Aurora or Beta and it needs to be disabled.

Bug 1069416 is about killing the #ifdefs etc. (once we're shipping symbols).
Summary: un-#ifdef ES6 symbols → Enable ES6 symbols by default
(Assignee)

Updated

3 years ago
Summary: Enable ES6 symbols by default → Enable ES6 symbols in all builds
(Assignee)

Updated

3 years ago
Depends on: 918828
(Assignee)

Updated

3 years ago
Depends on: 1058252
(Assignee)

Comment 2

3 years ago
Created attachment 8517269 [details] [diff] [review]
Enable ES6 symbols in all builds
Attachment #8517269 - Flags: review?(jdemooij)
(Assignee)

Updated

3 years ago
Assignee: nobody → jorendorff
Status: NEW → ASSIGNED
(Assignee)

Comment 3

3 years ago
Let's ship this.

I know Jeff would rather let it bake another cycle or two, but the fuzzers have been quiet for a long time now. And leaving it disabled also has costs and risks. Having tests break when we go to Aurora (due to the change in behavior caused by #ifdef NIGHTLY_ONLY) is a burden, writing "if (typeof Symbol...)" in every test in the first place is a burden, and there's work like bug 1054756 that's blocked on shipping this.
Comment on attachment 8517269 [details] [diff] [review]
Enable ES6 symbols in all builds

Review of attachment 8517269 [details] [diff] [review]:
-----------------------------------------------------------------

\o/ Nightly-only for 4 release cycles is certainly enough IMO.
Attachment #8517269 - Flags: review?(jdemooij) → review+
Btw, a blog post would be great. People love to know what we're doing, what's next etc.

(Or maybe an "ES6 status" post so that we can also mention some smaller features and stuff we're working on right now.)
Blocks: 1096313
(Assignee)

Comment 6

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/2077002427eb
https://hg.mozilla.org/mozilla-central/rev/2077002427eb
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
(In reply to Jan de Mooij [:jandem] from comment #5)
> Btw, a blog post would be great. People love to know what we're doing,
> what's next etc.
> 
> (Or maybe an "ES6 status" post so that we can also mention some smaller
> features and stuff we're working on right now.)

See also https://developer.mozilla.org/en-US/docs/Web/JavaScript/New_in_JavaScript/ECMAScript_6_support_in_Mozilla for inspiration.


For Symbols, I made sure to update Fx versions in the docs I posted in bug 645416 comment 169 to Fx36.

Firefox 36 for developers mentions Symbol now, too:
https://developer.mozilla.org/en-US/Firefox/Releases/36#JavaScript


Setting again relnote?, because this only made it to Aurora relnotes until now, I think.

Release Note Request (optional, but appreciated)
[Why is this notable]: More ES6 enabled, see bug 645416 comment 170 were we had this already.
[Suggested wording]:"Support for the ECMAScript 6 Symbol data type added (learn more)"
[Links (documentation, blog post, etc)]:
Learn more pointing to: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Symbol
relnote-firefox: --- → ?
Keywords: dev-doc-needed → dev-doc-complete
relnote-firefox: ? → 36+
You need to log in before you can comment on or make changes to this bug.