Closed
Bug 1066354
Opened 10 years ago
Closed 10 years ago
places.start() not changed to promise in browser migration
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(b2g-v2.1 unaffected, b2g-v2.2 fixed)
RESOLVED
FIXED
2.1 S5 (26sep)
| Tracking | Status | |
|---|---|---|
| b2g-v2.1 | --- | unaffected |
| b2g-v2.2 | --- | fixed |
People
(Reporter: qdot, Assigned: qdot)
References
Details
(Whiteboard: [systemsfe])
Attachments
(1 file)
Browser migration calls places.start() when trying to port places. However, once the places.start promise is finished, it never calls resolve, so migration just dies before we move anything.
|
Assignee | |
Comment 1•10 years ago
|
||
Well that explains why I couldn't figure this out. places.start() used to be a callback, is now a promise. Didn't get changed in migration to be a .then() call. Changing title to reflect difference in description.
Summary: places.start() never calls resolve for enclosing Promise → places.start() not changed to promise in browser migration
|
|
Assignee | |
Comment 2•10 years ago
|
||
Attachment #8488316 -
Flags: review?(dale)
|
|
Assignee | |
Comment 3•10 years ago
|
||
Setting flags to match bug 1062192. Guess we won't need uplift on this.
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8488316 [details] [review]
Patch 1 (v1) - Fix promise call for places in browser migration
Apologies for that, thanks for the fix
Attachment #8488316 -
Flags: review?(dale) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
|
||
Updated•10 years ago
|
Whiteboard: [systemsfe]
Target Milestone: --- → 2.1 S5 (26sep)
|
|
||
Updated•10 years ago
|
blocking-b2g: 2.2? → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•