Closed Bug 1066354 Opened 5 years ago Closed 5 years ago
.start() not changed to promise in browser migration
46 bytes, text/x-github-pull-request
|Details | Review|
Browser migration calls places.start() when trying to port places. However, once the places.start promise is finished, it never calls resolve, so migration just dies before we move anything.
Well that explains why I couldn't figure this out. places.start() used to be a callback, is now a promise. Didn't get changed in migration to be a .then() call. Changing title to reflect difference in description.
Summary: places.start() never calls resolve for enclosing Promise → places.start() not changed to promise in browser migration
Setting flags to match bug 1062192. Guess we won't need uplift on this.
Comment on attachment 8488316 [details] [review] Patch 1 (v1) - Fix promise call for places in browser migration Apologies for that, thanks for the fix
Attachment #8488316 - Flags: review?(dale) → review+
Target Milestone: --- → 2.1 S5 (26sep)
You need to log in before you can comment on or make changes to this bug.