1066450 - Serious Navigation bug for web audio editor in Fx35

Status: RESOLVED FIXED

(DevTools Graveyard :: Web Audio Editor, defect)

Description

[Jordan Santell [:jsantell] [@jsantell]]

Only in Fx35.0a1 (9/5/2014), not found in Fx34.0a1. Navigating to a page does not restart the WAE panel.

Recreation:
* Go to a page with audio [1] and load the WAE tools
* Navigate to a new page [2] with the tools still open
* Just waits on "Waiting for audio context to be created", can't refresh to get out of it without closing/reopening toolbox

[1] http://jsantell.github.io/dsp-with-web-audio-presentation/examples/fm.html
[2] http://jsantell.github.io/dsp-with-web-audio-presentation/examples/am.html

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Also in Fx35.0a1(2014-09-11)

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

This was introduced via bug 1053805

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Pinging Victor, should check out shader/canvas editors to see if bug 1053805 caused similar weirdness with those tools

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1066450-fix-navigation-wae-regression.patch

Reloading results in global X+1 being created, followed by global X being destroyed -- as call watcher's onGlobalDestroyed event occurs after the creation of the new global, the window matching in onGlobalDestroyed that pauses recording is never called in this case.

However, when navigating to a new page, global X is first destroyed, thus pausing recording, and then global X+1 is created with call watcher's `_recording` being off.

This fixes web audio, and we can roll a fix into call watcher itself if there are issues with shader/canvas editor.

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

https://tbpl.mozilla.org/?tree=Try&rev=c779e47394b8

Comment 6

[Victor Porof [:vporof][:vp]]

I've actually seen this happening a few times in the canvas tools too!

Comment 7

[Victor Porof [:vporof][:vp]]

Comment on attachment 8488582 [details] [diff] [review]
1066450-fix-navigation-wae-regression.patch

Review of attachment 8488582 [details] [diff] [review]:
-----------------------------------------------------------------

Canihaz dis for canvas.js?

Comment 8

[Jordan Santell [:jsantell] [@jsantell]]

Checking this in, opened bug 1070225 for canvas editor to apply a similar patch, will take care of that

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/4d9e5795ee82

Comment 10

[Carsten Book [:Tomcat]]

seems some failures were related to this changeset too like https://tbpl.mozilla.org/php/getParsedLog.php?id=48568065&tree=Fx-Team so i had to backout this too

Comment 11

[Jordan Santell [:jsantell] [@jsantell]]

What are the other failures? I can't imagine a change in a dev tool panel causing plugin failures within the browser..

Comment 12

[Jordan Santell [:jsantell] [@jsantell]]

Note to self, fix tests to pass with ES6 lexical temporal dead zone[1]

[1]http://comments.gmane.org/gmane.comp.mozilla.devel.platform/10488

Comment 13

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1066450-fix-navigation-wae-regression.patch

Updated patch with `let` lexical changes, new try: https://tbpl.mozilla.org/?tree=Try&rev=0a9ed27ad436

Comment 14

[Jordan Santell [:jsantell] [@jsantell]]

Try looking good after `let` changes

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/5a03ab3af00f

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5a03ab3af00f