Closed Bug 1066450 Opened 8 years ago Closed 8 years ago

Serious Navigation bug for web audio editor in Fx35

Categories

(DevTools Graveyard :: Web Audio Editor, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 35

People

(Reporter: jsantell, Assigned: jsantell)

References

Details

Attachments

(1 file, 1 obsolete file)

Only in Fx35.0a1 (9/5/2014), not found in Fx34.0a1. Navigating to a page does not restart the WAE panel.

Recreation:
* Go to a page with audio [1] and load the WAE tools
* Navigate to a new page [2] with the tools still open
* Just waits on "Waiting for audio context to be created", can't refresh to get out of it without closing/reopening toolbox

[1] http://jsantell.github.io/dsp-with-web-audio-presentation/examples/fm.html
[2] http://jsantell.github.io/dsp-with-web-audio-presentation/examples/am.html
Also in Fx35.0a1(2014-09-11)
This was introduced via bug 1053805
Pinging Victor, should check out shader/canvas editors to see if bug 1053805 caused similar weirdness with those tools
Flags: needinfo?(vporof)
Reloading results in global X+1 being created, followed by global X being destroyed -- as call watcher's onGlobalDestroyed event occurs after the creation of the new global, the window matching in onGlobalDestroyed that pauses recording is never called in this case.

However, when navigating to a new page, global X is first destroyed, thus pausing recording, and then global X+1 is created with call watcher's `_recording` being off.

This fixes web audio, and we can roll a fix into call watcher itself if there are issues with shader/canvas editor.
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Attachment #8488582 - Flags: review?(vporof)
I've actually seen this happening a few times in the canvas tools too!
Flags: needinfo?(vporof)
Comment on attachment 8488582 [details] [diff] [review]
1066450-fix-navigation-wae-regression.patch

Review of attachment 8488582 [details] [diff] [review]:
-----------------------------------------------------------------

Canihaz dis for canvas.js?
Attachment #8488582 - Flags: review?(vporof) → review+
Checking this in, opened bug 1070225 for canvas editor to apply a similar patch, will take care of that
Keywords: checkin-needed
seems some failures were related to this changeset too like https://tbpl.mozilla.org/php/getParsedLog.php?id=48568065&tree=Fx-Team so i had to backout this too
Whiteboard: [fixed-in-fx-team]
What are the other failures? I can't imagine a change in a dev tool panel causing plugin failures within the browser..
Note to self, fix tests to pass with ES6 lexical temporal dead zone[1]

[1]http://comments.gmane.org/gmane.comp.mozilla.devel.platform/10488
Updated patch with `let` lexical changes, new try: https://tbpl.mozilla.org/?tree=Try&rev=0a9ed27ad436
Attachment #8488582 - Attachment is obsolete: true
Attachment #8493225 - Flags: review+
Try looking good after `let` changes
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/5a03ab3af00f
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/5a03ab3af00f
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 35
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.