Closed Bug 1066514 Opened 10 years ago Closed 10 years ago

Rename home_history_list layout and HistoryListView style

Categories

(Firefox for Android Graveyard :: Awesomescreen, defect)

Product:
Firefox for Android Graveyard
Component:
Awesomescreen
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 35

People

(Reporter: Margaret, Assigned: lviknesh, Mentored)

References

Details

(Whiteboard: [lang=java])

Attachments

(1 file, 2 obsolete files)

rebased
8.66 KB, patch
Details | Diff | Splinter Review
This layout is now used in both the history panel and the recent tabs panel, so we should give it a more generic name. Maybe just home_list?
Can you link up where this lives in the source?
Attached patch rename-home-list (obsolete) — — Splinter Review
Assignee: nobody → lviknesh
Attachment #8490286 - Flags: feedback?(margaret.leibovic)
Comment on attachment 8490286 [details] [diff] [review] rename-home-list Review of attachment 8490286 [details] [diff] [review]: ----------------------------------------------------------------- Looking good! You should also rename the HistoryListView style to HomeList. Here's a search of where that's used: http://mxr.mozilla.org/mozilla-central/search?find=/mobile/android/&string=historylistview
Attachment #8490286 - Flags: feedback?(margaret.leibovic) → feedback+
Attached patch rename-final.patch (obsolete) — — Splinter Review
Attachment #8490286 - Attachment is obsolete: true
Attachment #8490903 - Flags: review?(margaret.leibovic)
Comment on attachment 8490903 [details] [diff] [review] rename-final.patch Review of attachment 8490903 [details] [diff] [review]: ----------------------------------------------------------------- This looks good but unfortunately it didn't apply to the latest fx-team. You should update your tree and rebase, and then I can help you land this.
Attachment #8490903 - Flags: review?(margaret.leibovic) → review+
Attached patch rebased — — Splinter Review
Attachment #8490903 - Attachment is obsolete: true
Flags: needinfo?(margaret.leibovic)
Thanks! https://hg.mozilla.org/integration/fx-team/rev/e724a389c605
Flags: needinfo?(margaret.leibovic)
https://hg.mozilla.org/mozilla-central/rev/e724a389c605
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: