Closed Bug 1066530 Opened 10 years ago Closed 10 years ago

message app tap_back_button doesn't work with new gaia-header

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::UI Tests
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.1 affected)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
b2g-v2.1 --- affected

People

(Reporter: pyang, Assigned: RobertC)

References

Details

Attachments

(2 files)

bug 1066530 patch for apps/contact/region/message_thread.py
46 bytes, text/x-github-pull-request
viorela
: review+
RobertC
: review+
zcampbell
: feedback+
Details | Review
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24289
46 bytes, text/x-github-pull-request
Bebe
: review+
Details | Review 
STR: Run tap_back_button() in apps/messages/regions/message_threads.py

EXPECT: Tap back button and successfully back to main screen

ACTUAL: Tap message header and show interactive menu
Need this function fixed to run continuously.
Attachment #8489243 - Flags: feedback?(zcampbell)
Summary: tap_back_button doesn't work with new gaia-header → contact app tap_back_button doesn't work with new gaia-header
Comment on attachment 8489243 [details] [review]
bug 1066530 patch for apps/contact/region/message_thread.py

Is back button stored in the shadow dom? 

Let's just add a comment explaining why we are doing (25, 25)

If the reason is shadow dom then reference this bug in the comment:
https://bugzilla.mozilla.org/show_bug.cgi?id=1061698

I'll hand it to viorela and robertc to r?
Attachment #8489243 - Flags: review?(viorela.ioia)
Attachment #8489243 - Flags: review?(robert.chira)
Attachment #8489243 - Flags: feedback?(zcampbell)
Attachment #8489243 - Flags: feedback+
Yes, I can't see back_button but only message header.
Glad to add bug id in comments since it is workaround.
Summary: contact app tap_back_button doesn't work with new gaia-header → message app tap_back_button doesn't work with new gaia-header
Comment on attachment 8489243 [details] [review]
bug 1066530 patch for apps/contact/region/message_thread.py

r+, but please update the comment. Thanks!
Attachment #8489243 - Flags: review?(viorela.ioia) → review+
Comment on attachment 8489243 [details] [review]
bug 1066530 patch for apps/contact/region/message_thread.py

r+ from me, but please address the comment from the PR before merging.
Attachment #8489243 - Flags: review?(robert.chira) → review+
Thanks for review!
Merged in master:
https://github.com/mozilla-b2g/gaia/commit/af7a375b8cf6ca462804a66a8ff72a93700762e3
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Can we uplift this to v2.1 branch?
status-b2g-v2.1: --- → affected
Flags: needinfo?(robert.chira)
Uplift to v2.1
Attachment #8493028 - Flags: review?(viorela.ioia)
Attachment #8493028 - Flags: review?(florin.strugariu)
Flags: needinfo?(robert.chira)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #8493028 - Flags: review?(viorela.ioia)
Attachment #8493028 - Flags: review?(florin.strugariu)
Attachment #8493028 - Flags: review+
https://github.com/mozilla-b2g/gaia/commit/689c4ad4d8c3e4aa95805a2e49ae6cf786a1ae91
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Thanks!
Depends on: 1082938
Assignee: nobody → robert.chira
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: