1066663 - Selecting text with e10s autostart usually fails with first attempt

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Sometimes when I try to select text in my e10s environment, nothing happens. When I retry to select the text, the selection works as expected.

I think there is a focus issue with e10s, maybe when coming from a separate application, but I can't reproduce this issue 100% of the time.

I have seen it about 5 times though.

Tested on Windows 7 Nightly 2014-09-12 with e10s autostart enabled.

Comment 1

[Kestrel]

Steps:

1. Click inside urlbar or searchbox to move focus there.
2. Mousedown inside page contents and drag over text to start a selection. 

Results:

Nothing will happen, have to mousedown again to start selection.

Expected:

First mousedown and drag inside page should start selection.

Comment 2

[Jim Mathies [:jimm]]

(In reply to Kestrel from comment #1)
> Steps:
> 
> 1. Click inside urlbar or searchbox to move focus there.
> 2. Mousedown inside page contents and drag over text to start a selection. 
> 
> Results:
> 
> Nothing will happen, have to mousedown again to start selection.
> 
> Expected:
> 
> First mousedown and drag inside page should start selection.

Using these steps I can reliably reproduce. This needs to get fixed, but it feels like polish, moving to M8.

Comment 4

[Kestrel]

Not fixed for me in latest Nightly, can still reproduce using above steps.

Comment 5

[Neil Deakin]

The first patch in bug 1123422 fixes this, but the different one that was checked in was only a fix for that bug.

Comment 6

[Neil Deakin]

Attachment: dragselect

The code here that sets SetDragState is used to clear the selection state when switching windows. Without it, for example, you can Ctrl+tab while selecting some text and then Ctrl+tab back and still be selecting. This is the issue for the bug that added this code long ago.

However, this state can be reset when the window is lowered instead, and fix this bug as well.

Comment 7

[Neil Deakin]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/a9787cd39303b0f2197322e11cbb1c89b2f500d8
changeset:  a9787cd39303b0f2197322e11cbb1c89b2f500d8
user:       Neil Deakin <[e-mail]>
date:       Wed Jul 15 14:55:18 2015 -0400
description:
Bug 1066663, move call to SetDragState to happen when a window is lowered to avoid the issue with selection being prevented, r=smaug

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a9787cd39303