Closed
Bug 1066718
Opened 7 years ago
Closed 7 years ago
crash in nsScriptSecurityManager::AddSitesToFileURIWhitelist(nsCString const&)
Categories
(Core :: Security: CAPS, defect)
Tracking
()
VERIFIED
FIXED
mozilla35
People
(Reporter: kairo, Assigned: bholley)
References
Details
(Keywords: crash, regression)
Crash Data
Attachments
(1 file)
1.09 KB,
patch
|
bzbarsky
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
Sylvestre
:
approval-mozilla-esr31+
|
Details | Diff | Splinter Review |
This bug was filed from the Socorro interface and is report bp-dbe0ca2c-53cc-4f07-82a9-a8def2140910. ============================================================= This is a startup crash of the main process with e10s enabled that is rising significantly now that we nudge people to try e10s. Find stats and more reports at https://crash-stats.mozilla.com/report/list?product=Firefox&signature=nsScriptSecurityManager%3A%3AAddSitesToFileURIWhitelist%28nsCString+const%26%29
![]() |
Reporter | |
Comment 1•7 years ago
|
||
Sorry, this is actually mostly happening in the *content* process, but some of those are also in the main "browser" process.
We're calling ExtractScheme on a null sIOService.
Blocks: 1061136
Flags: needinfo?(bobbyholley)
Assignee | ||
Comment 3•7 years ago
|
||
Yeah, this basically crashes for everyone who has the caps fileURI prefs set up. The problem is that the test sets the prefs dynamically long after startup, and so we don't hit this crash. We'll need to take this on all the branches where we uplifted bug 1061136.
Assignee | ||
Comment 4•7 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=b9597630db49
Assignee | ||
Comment 5•7 years ago
|
||
Attachment #8489992 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 6•7 years ago
|
||
Comment on attachment 8489992 [details] [diff] [review] Get sIOService before invoking ReadPrefs. v1 This is regression from bug 1061136 that will cause it to crash for pretty much everyone who uses this machinery. This fix needs to follow that one.
Attachment #8489992 -
Flags: approval-mozilla-esr31?
Attachment #8489992 -
Flags: approval-mozilla-beta?
Attachment #8489992 -
Flags: approval-mozilla-aurora?
Comment 7•7 years ago
|
||
Comment 0 says that this crash only occurs when e10s is enabled. e10s is currently disabled by default everywhere. This is a trivial fix but still should only be uplifted where necessary. I'm happy to uplift to aurora and will accept on beta if we're asking people to enable e10s there. I don't think we need to uplift to esr31, on which we will never enable e10s and on which the user base has no expectation of bleeding edge features.
Assignee | ||
Comment 8•7 years ago
|
||
(In reply to Lawrence Mandel [:lmandel] from comment #7) > Comment 0 says that this crash only occurs when e10s is enabled. e10s is > currently disabled by default everywhere. This is a trivial fix but still > should only be uplifted where necessary. I'm happy to uplift to aurora and > will accept on beta if we're asking people to enable e10s there. I don't > think we need to uplift to esr31, on which we will never enable e10s and on > which the user base has no expectation of bleeding edge features. I don't understand why this would be e10s-only. By my reading of the code, it should be happening to anyone that has the CAPS prefs set. I can investigate this if you like, but the fix is super-safe (just grabbing a pointer to the global IOService one line earlier), so I think we could also just uplift it and move on.
![]() |
Reporter | |
Comment 9•7 years ago
|
||
(In reply to Lawrence Mandel [:lmandel] from comment #7) > Comment 0 says that this crash only occurs when e10s is enabled. So, I thought this would be related due to when it started spiking but I took the wrong conclusions to the data I was seeing. This also happens where e10s is disabled, the way our queries work did confuse me. As Bobby says that it's caused by using what bug 1061136 introduces, we should see to land this everywhere we land(ed) that other patch as well.
Summary: e10s crash in nsScriptSecurityManager::AddSitesToFileURIWhitelist(nsCString const&) → crash in nsScriptSecurityManager::AddSitesToFileURIWhitelist(nsCString const&)
![]() |
||
Comment 10•7 years ago
|
||
Comment on attachment 8489992 [details] [diff] [review] Get sIOService before invoking ReadPrefs. v1 r=me
Attachment #8489992 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 11•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/82824b25afee
https://hg.mozilla.org/mozilla-central/rev/82824b25afee
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Updated•7 years ago
|
Attachment #8489992 -
Flags: approval-mozilla-esr31?
Attachment #8489992 -
Flags: approval-mozilla-esr31+
Attachment #8489992 -
Flags: approval-mozilla-beta?
Attachment #8489992 -
Flags: approval-mozilla-beta+
Attachment #8489992 -
Flags: approval-mozilla-aurora?
Attachment #8489992 -
Flags: approval-mozilla-aurora+
Comment 13•7 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/d7ad9b5167d8 https://hg.mozilla.org/releases/mozilla-beta/rev/262de5944a01 https://hg.mozilla.org/releases/mozilla-esr31/rev/6f935c70e194
status-firefox32:
--- → unaffected
status-firefox33:
--- → fixed
status-firefox34:
--- → fixed
status-firefox35:
--- → fixed
status-firefox-esr31:
--- → fixed
Updated•7 years ago
|
tracking-firefox-esr31:
--- → 33+
Comment 14•6 years ago
|
||
Closing this bug since Socorro [1] shows no more crashes on 33 (after Beta 4), 34 and 35 for the past 4 weeks. [1] - https://crash-stats.mozilla.com/report/list?product=Firefox&range_unit=days&range_value=28&signature=nsScriptSecurityManager%3A%3AAddSitesToFileURIWhitelist%28nsCString+const%26%29
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•