Make the search bar's autocomplete popup/tree's styling match the spec in bug 1054951

NEW
Unassigned

Status

()

Firefox
General
4 years ago
10 months ago

People

(Reporter: adw, Unassigned)

Tracking

Trunk
Points:
5
Bug Flags:
firefox-backlog +
qe-verify +

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

4 years ago
Make the search bar's autocomplete popup/tree's styling match the spec in bug 1054951.

Filed in Firefox::General but this may involve changing http://mxr.mozilla.org/mozilla-central/source/toolkit/components/autocomplete/nsAutoCompleteController.cpp too.

The popup is the PopupAutoComplete panel in browser.xul.  It looks like nsAutoCompleteController fills in the popup, with a xul:tree.

The tree is styled by the browser.css's in the themes directory, e.g., http://mxr.mozilla.org/mozilla-central/source/browser/themes/osx/browser.css.  (See the /* ----- AUTOCOMPLETE ----- */ section.)

The "Suggestions" comment string that appears at the top of the search suggestions section in the main search bar's popup is part of the results returned by nsSearchSuggestions.js and SearchSuggestionController.  It ends up being returned by FormAutoCompleteResult.prototype.getCommentAt, which nsAutoCompleteController  calls to set tree cell text.  nsAutoCompleteController also calls getStyleAt, which is how the popup's separator between form history results and search provider results is drawn, along with a border in the CSS in the browser.css's.
Flags: qe-verify+
Flags: firefox-backlog+
You need to log in before you can comment on or make changes to this bug.