1066911 - add test for eRestyle_{Force,ForceDescendants} to nsStyleSet::RuleNodeWithReplacement

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This is merging between bug 996796 and bug 931668, though doesn't actually lead to test failures until further patches (which were green on try prior to bug 931668 landing, but now orange with a crashtest assertion in layout/tables/crashtests/399209-1.xhtml).

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Allow eRestyle_Force{,Descendants} in RuleNodeWithReplacement

This is fine since the assertion is just checking that we're not calling
RuleNodeWithReplacement in cases when stronger restyling (i.e.,
restyling that does more work) is needed; the new eRestyle_Force and
eRestyle_ForceDescendants flags control whether we restyle at all.

This probably should have been done in bug 931668 (since bug 996796
landed before bug 931668, although not before the patches were written),
but it doesn't actually show up in our test suite until bug 977991 (or
maybe slightly earlier in bug 1057231 or bug 1058346).

Comment 2

[Cameron McCormack (:heycam)]

Comment on attachment 8488954 [details] [diff] [review]
Allow eRestyle_Force{,Descendants} in RuleNodeWithReplacement

Review of attachment 8488954 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/style/nsStyleSet.cpp
@@ +1341,2 @@
>                      // FIXME: Once bug 931668 lands we'll have a better
>                      // way to print these.

The nsRestyleHint -> nsCString function is in bug 979133, btw.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://tbpl.mozilla.org/?tree=Try&rev=af63febbc619
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=af63febbc619

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/310f2eaded12

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/310f2eaded12