add test for eRestyle_{Force,ForceDescendants} to nsStyleSet::RuleNodeWithReplacement

RESOLVED FIXED in mozilla35

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

Trunk
mozilla35
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

This is merging between bug 996796 and bug 931668, though doesn't actually lead to test failures until further patches (which were green on try prior to bug 931668 landing, but now orange with a crashtest assertion in layout/tables/crashtests/399209-1.xhtml).
Created attachment 8488954 [details] [diff] [review]
Allow eRestyle_Force{,Descendants} in RuleNodeWithReplacement

This is fine since the assertion is just checking that we're not calling
RuleNodeWithReplacement in cases when stronger restyling (i.e.,
restyling that does more work) is needed; the new eRestyle_Force and
eRestyle_ForceDescendants flags control whether we restyle at all.

This probably should have been done in bug 931668 (since bug 996796
landed before bug 931668, although not before the patches were written),
but it doesn't actually show up in our test suite until bug 977991 (or
maybe slightly earlier in bug 1057231 or bug 1058346).
Attachment #8488954 - Flags: review?(cam)
Comment on attachment 8488954 [details] [diff] [review]
Allow eRestyle_Force{,Descendants} in RuleNodeWithReplacement

Review of attachment 8488954 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/style/nsStyleSet.cpp
@@ +1341,2 @@
>                      // FIXME: Once bug 931668 lands we'll have a better
>                      // way to print these.

The nsRestyleHint -> nsCString function is in bug 979133, btw.
Attachment #8488954 - Flags: review?(cam) → review+
https://hg.mozilla.org/mozilla-central/rev/310f2eaded12
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.