Assertion failure: aEntry->IsDirty(), in mozilla::net::CacheIndex::UpdateEntryInIndex in netwerk/cache2/CacheIndex.cpp

RESOLVED FIXED in mozilla36

Status

()

Core
Networking: Cache
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: dbaron, Assigned: michal)

Tracking

({assertion, crash})

Trunk
mozilla36
x86_64
Linux
assertion, crash
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Created attachment 8488960 [details]
debugging

I was looking at something on www.flickr.com when I crashed due to:

Assertion failure: aEntry->IsDirty(), at /home/dbaron/builds/ssd/mozilla-central
/mozilla/netwerk/cache2/CacheIndex.cpp:1492

in mozilla::net::CacheIndex::UpdateEntryInIndex.

I was using revision bad6a9fc2bf0 plus my patch queue as of Fri Sep 12 08:18:05 2014 -0700 (up to comment-js-assert-bug-1057580).
(Assignee)

Comment 1

4 years ago
Created attachment 8497504 [details] [diff] [review]
fix

The assertion is too strict. There is one case in CacheIndex::EnsureEntryExists() when we create an entry in mPendingUpdates to make the entry fresh without marking it as dirty.
Assignee: nobody → michal.novotny
Attachment #8497504 - Flags: review?(honzab.moz)
Comment on attachment 8497504 [details] [diff] [review]
fix

Review of attachment 8497504 [details] [diff] [review]:
-----------------------------------------------------------------

I believe you :)
Attachment #8497504 - Flags: review?(honzab.moz) → review+
https://hg.mozilla.org/mozilla-central/rev/bc87d0ccf6a9
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.