1067007 - [mozmill] tests do not work after TB build changes

Status: RESOLVED FIXED

(Calendar :: General, defect, P1)

Description

[Markus Adrario [:Taraman]]

After the recent build changes the calendar mozmill tests are not running.

The paths still point to "$objdir$/mozilla/<somedir>" ISO "$objdir$/<somedir>"

Comment 1

[Philipp Kewisch [:Fallen][📱📆]]

Thanks for filing the bug, I just noticed this on the tryserver too. Try run with patch applied:

https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=12f7cd74972c

Comment 2

[Markus Adrario [:Taraman]]

The Try Run passed, but the calendar-tests don't seem to be executed.
searching the log for testTodayPane.js which should run show no results.

I tried the same change locally and when running "make -C objdir/calendar/test/mozmill mozmill" I get the error "Binary does not exist: ../../../dist/bin/tunderbird"
The path would be right from objdir/calendar/test/mozmill, but the script seems to run in a different location.

Comment 3

[Philipp Kewisch [:Fallen][📱📆]]

Does running Thunderbird mozmill tests work for you? I tried make mozmill in objdir, but that complains about a missing mozinfo. Installing that into the virtualenv also gives me the error you are getting: 

Exception: Binary path does not exist ../../../dist/Daily.app/Contents/MacOS/thunderbird-bin

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

Could try packaging tests and seeing if it runs then.

Comment 5

[Philipp Kewisch [:Fallen][📱📆]]

New try run, I've tested the changes locally and they at least show up in packaged tests' mozmilltests.list now.

https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=b1f015505939

Comment 6

[Markus Adrario [:Taraman]]

Attachment: cal-mozmill-new-build.diff

TB mozmill tests work for me loacally.

I played around a little and this patch fixes this for me on linux.
I don't know from where the relative path should fit, but absolute works.

Comment 7

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v2

This patch contains the changes you've suggested previously, plus some extra changes to make sure the mozmill tests are run when packaged.

Here is a tryserver run that succeeds in so far that the calendar tests are run. The failing imip test is bug 1010294 which is not ready yet, but the other calendar mozmill tests are running.

https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=b1f015505939

Comment 8

[Philipp Kewisch [:Fallen][📱📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/f1fe79198f96>