Closed
Bug 1067064
Opened 11 years ago
Closed 11 years ago
add retn to the none MacroAssembler
Categories
(Core :: JavaScript Engine: JIT, defect)
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: stevensn, Assigned: stevensn)
References
Details
Attachments
(1 file)
|
1.43 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
Bug 1047346 added a call to masm.retn to JitRuntime::generateLazyLinkStub but the none macroassembler does
not define retn resulting in a compile time error
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8489071 -
Flags: review?(jdemooij)
|
|
Assignee | |
Comment 2•11 years ago
|
||
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8489071 [details] [diff] [review]
add_retn.diff
Review of attachment 8489071 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, thanks!
(Note that the jit/none/* code is not exercised at all on TBPL (or we wouldn't have this bug), so an all-platforms + all-tests run is a bit of a waste :)
Attachment #8489071 -
Flags: review?(jdemooij) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 4•11 years ago
|
||
Assignee: nobody → steve
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
|
||
Comment 6•11 years ago
|
||
Good find. Thanks!
You need to log in
before you can comment on or make changes to this bug.
Description
•