1067232 - [SMS] Avoid to make a private memory copy for file based blob

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Steve Chung [:steveck]]

After bug 1059233, we will create a private copy for data return from picker to avoid any possible crash by accessing the memory-based blob. But there is no need to make a copy for file-based blob. We need to specify that only memory-based image blob(cropped image) need to have a copy in message app.

Comment 1

[Steve Chung [:steveck]]

Oleg, thanks for the reminder in bug 1059233. It's one line changes in compose.js but I have no proper way for the test case. Do you have a good idea to create a file-based blob for assertion?

Comment 2

[Oleg Zasypkin [:azasypkin]]

It's hard to say without seeing actual test :) But maybe we can use "test/unit/assets_helper.js" for this and tune "loadFileBlob" [1] a bit, like:

.....
// Or maybe directly arraybuffer, but I don't know how to get correct type for File then
xhr.responseType = 'blob';
xhr.onload = function() {
  var fileReader = new FileReader();
  fileReader.onload = function() {
    resolve(new File([this.result], filePath, {
      type: xhr.response.type
    }));
  };
  fileReader.readAsArrayBuffer(xhr.response);
};
....

Or maybe just dumb File constructor will work (new File([], ....)), depends on test case

[1] https://github.com/mozilla-b2g/gaia/blob/3cb88f9f55725a3be107127cf6936bc7ffd9452a/apps/sms/test/unit/assets_helper.js#L53

Comment 3

[Julien Wajsberg [:julienw]]

This bug is now invalid :)