Closed Bug 1067248 Opened 5 years ago Closed 5 years ago

Ccache is prepended twice in building NSPR

Categories

(Firefox Build System :: General, defect)

28 Branch
x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla35

People

(Reporter: cyu, Assigned: cyu)

References

Details

Attachments

(1 file)

This is the side effect of bug 1066669 in changing \S* to [^ ]* to fix that sed on Mac doesn't support \S. The change doesn't work correctly and we need to escape [ to make it work.
Blocks: 1066669
Assignee: nobody → cyu
Attachment #8489252 - Flags: review?(ted)
CC Kanru. Thanks for his help in debugging this.
Comment on attachment 8489252 [details] [diff] [review]
fix_strip_ccache.patch

Review of attachment 8489252 [details] [diff] [review]:
-----------------------------------------------------------------

Oh god this is all terrible
Attachment #8489252 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/a07aa431457b
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Depends on: 1081682
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.