Closed
Bug 1067248
Opened 11 years ago
Closed 11 years ago
Ccache is prepended twice in building NSPR
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla35
People
(Reporter: cyu, Assigned: cyu)
References
Details
Attachments
(1 file)
|
1.02 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
This is the side effect of bug 1066669 in changing \S* to [^ ]* to fix that sed on Mac doesn't support \S. The change doesn't work correctly and we need to escape [ to make it work.
|
Assignee | |
Comment 1•11 years ago
|
||
Assignee: nobody → cyu
Attachment #8489252 -
Flags: review?(ted)
|
|
Assignee | |
Comment 2•11 years ago
|
||
CC Kanru. Thanks for his help in debugging this.
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8489252 [details] [diff] [review]
fix_strip_ccache.patch
Review of attachment 8489252 [details] [diff] [review]:
-----------------------------------------------------------------
Oh god this is all terrible
Attachment #8489252 -
Flags: review?(ted) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•