1067260 - Backing up a certificate shows a "warning" type alert when action was successful

Status: RESOLVED DUPLICATE of bug 1239344

(Core :: Security: PSM, defect, P5)

Description

[Blaise Kal]

Attachment: Screenshot 2014-09-15 10.45.32.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:32.0) Gecko/20100101 Firefox/32.0
Build ID: 20140825202822

Steps to reproduce:

1. Go to Preferences > Advanced > Certificates
2. Click the "View Certificates" button
3. Select a certificate in "Your Certificates" (you may not have one, I don't know how to create it, mine was a startcom login certificate. You may be able to create a self-signed certificate somehow.)
4. Click the "Backup..." button and click Save
5. Enter a passphrase


Actual results:

After step 5, I get a success confirmation message that looks like a warning.


Expected results:

After step 5, I get a success confirmation that looks like a information window.

Comment 1

[:Cykesiopka]

This occurs on my local Linux build as well.

It looks like this occurs because the success case ends up calling handleError(),
which calls ShowAlertFromStringBundle():
> nsPKCS12Blob::handleError(int myerr)
> {
>   ...
>   switch (myerr) {
>   case PIP_PKCS12_RESTORE_OK:       msgID = "SuccessfulP12Restore"; break;
>   case PIP_PKCS12_BACKUP_OK:        msgID = "SuccessfulP12Backup";  break;
>   case PIP_PKCS12_USER_CANCELED:
>     return;  /* Just ignore it for now */
>   ...
>   }
>   ...
>   if (NS_SUCCEEDED(rv))
>     (void) nssComponent->ShowAlertFromStringBundle(msgID);
> }
https://hg.mozilla.org/mozilla-central/annotate/3acf9162f52d/security/manager/ssl/src/nsPKCS12Blob.cpp#l721