Closed
Bug 1067268
Opened 10 years ago
Closed 10 years ago
Headings in the facebook side bar with RTL UI are misplaced
Categories
(Core :: Layout: Text and Fonts, defect)
Core
Layout: Text and Fonts
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: smontagu, Assigned: smontagu)
References
Details
(Keywords: regression)
Attachments
(4 files)
3.39 KB,
image/png
|
Details | |
628 bytes,
text/html
|
Details | |
2.36 KB,
patch
|
jfkthame
:
review+
lmandel
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
2.65 KB,
patch
|
jfkthame
:
review+
|
Details | Diff | Splinter Review |
I don't see this all the time, and attempts to select the text to view selection source seem to change the behaviour, but I'll work on a minimized testcase. Regression range is http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=bdac18bd6c74&tochange=776f6d341b3f, and it's probably caused by http://hg.mozilla.org/mozilla-central/rev/8bc5711c589e from bug 789096
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8499201 -
Flags: review?(jfkthame)
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8499214 -
Flags: review?(jfkthame)
Assignee | ||
Comment 4•10 years ago
|
||
[Tracking Requested - why for this release]:
status-firefox32:
--- → unaffected
status-firefox33:
--- → affected
status-firefox34:
--- → affected
tracking-firefox33:
--- → ?
tracking-firefox34:
--- → ?
Patch seems reasonable to me for now; eventually we'll want all of this to be logicalized so that it works for floats in vertical layout, but definitely better to be consistent for now than try to compute a width by subtracting a logical and a physical coordinate from each other.
Comment 6•10 years ago
|
||
33 beta 9 is going to be released today and you didn't fill a reason for tracking in comment #4. Except if it is a critical issue, 33 will ship with this bug.
Comment 7•10 years ago
|
||
Comment on attachment 8499201 [details] [diff] [review]
Patch
Review of attachment 8499201 [details] [diff] [review]:
-----------------------------------------------------------------
What dbaron said.
Attachment #8499201 -
Flags: review?(jfkthame) → review+
Updated•10 years ago
|
Attachment #8499214 -
Flags: review?(jfkthame) → review+
Assignee | ||
Comment 8•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/69910e2c2a5d
https://hg.mozilla.org/integration/mozilla-inbound/rev/9cafd64208c3
Flags: in-testsuite+
Comment 9•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/69910e2c2a5d
https://hg.mozilla.org/mozilla-central/rev/9cafd64208c3
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Updated•10 years ago
|
Flags: qe-verify-
Updated•10 years ago
|
status-firefox35:
--- → fixed
Comment 10•10 years ago
|
||
Simon, do you think this should be uplift to aurora?
Flags: needinfo?(smontagu)
Assignee | ||
Comment 11•10 years ago
|
||
Comment on attachment 8499201 [details] [diff] [review]
Patch
Approval Request Comment
[Feature/regressing bug #]: Bug 789096
[User impact if declined]: Overlapping unreadable content in right-to-left languages
[Describe test coverage new/current, TBPL]: reftest in second patch, fix baked on trunk since 2014-10-05
[Risks and why]: mimimal risk
[String/UUID change made/needed]: N/A
Attachment #8499201 -
Flags: approval-mozilla-aurora?
Flags: needinfo?(smontagu)
Updated•10 years ago
|
Attachment #8499201 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 12•10 years ago
|
||
Comment on attachment 8499201 [details] [diff] [review]
Patch
Actually, setting it back to aurora="?" and adding beta="?" since it is merge day!
Attachment #8499201 -
Flags: approval-mozilla-beta?
Attachment #8499201 -
Flags: approval-mozilla-aurora?
Attachment #8499201 -
Flags: approval-mozilla-aurora+
Updated•10 years ago
|
Updated•10 years ago
|
Attachment #8499201 -
Flags: approval-mozilla-aurora?
Comment 13•10 years ago
|
||
Comment on attachment 8499201 [details] [diff] [review]
Patch
Beta+
Attachment #8499201 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 14•10 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•