1067275 - [Messages] Deleting a thread is needlessly difficult (6 button presses!)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Shane Tomlinson [:stomlinson]]

Deleting an SMS thread is needlessly difficult if viewing a list of all threads.

1. open the thread
2. tap the gear
3. press "delete messages"
4. press "select all"
5. press "delete"
6. press confirmation "delete"

This is too much work.

From step 1, we should be able to tap and hold on the thread to view a menu, tap a "delete thread" button, confirm, and be done.

Device: Flame
Build ID: 20140910000203

Comment 1

[Julien Wajsberg [:julienw]]

NI Jenny on this.

I think this could be a nice addition !

Comment 2

[Jenny Lee]

Attachment: [1.5 Messages] Select Items v1.3.pdf

Ya I agree. See attached for updated spec.

Hey Julien, is Kumar still working on select mode? If so, will he take this one too? Thanks!

Comment 3

[Julien Wajsberg [:julienw]]

Just to be clear: this bug is _only_ about implementing the longpress gesture.

(I see that the spec has a "undo" mechanism, this is _not_ in the scope of this bug).

Until we have the "undo" mechanism, I think we still want a confirm dialog if we use "longpress > delete". Do you agree Jenny?

Kumar, are you working on something currently, or do you want to take this as well? It's ok if you can't, so feel free to reject :) we can make this bug a mentored bug for someone else to pick it :)

Comment 4

[Jenny Lee]

(In reply to Julien Wajsberg [:julienw] from comment #3)
> Just to be clear: this bug is _only_ about implementing the longpress
> gesture.
> 
> (I see that the spec has a "undo" mechanism, this is _not_ in the scope of
> this bug).
> 
> Until we have the "undo" mechanism, I think we still want a confirm dialog
> if we use "longpress > delete". Do you agree Jenny?

I'm ok with this!

> 
> Kumar, are you working on something currently, or do you want to take this
> as well? It's ok if you can't, so feel free to reject :) we can make this
> bug a mentored bug for someone else to pick it :)

Comment 5

[kumar rishav (:rishav_)]

Hi
I am ready to take this bug. But i would like to give some suggestions .
1) It's good (in terms to visual look too) to have read/unread and delete in icons rather than in option mode.
2) Currently we are implementing the icons instead of text.

My POV :
* Long press on thread > select mode (instead of option dialog box) > from here as it is in bug 829820.

* Setting icon  in top right corner and no need of 'more' icon (three horizontal dots)....as select thread mode will come in long press.
 or
setting icon in top left corner and 'more' icon (three dots) in top right corner...tapping on which take you to select more directly.

* we should remove confirmation or option selecting dialog box whereever it's possible.
In email app too we go to edit mode in one tapping instead of option dialog box.

Thanks

Comment 6

[kumar rishav (:rishav_)]

Isn't the ux-flow better in v1.3? 
like: 
Enter the select mode on one tap (tapping the tick icon in top left corner)
Setting option after entering in thread (along with select message and add subject options).

Comment 7

[Julien Wajsberg [:julienw]]

These are questions for Jenny.

I think that longpressing on a thread should act on this thread, and not act globally, so I'd rather keep a menu on longpressing.
For the other suggestions, I quite agree with you, but these changes were made for some reason and Jenny will know better than me.

Comment 8

[Jenny Lee]

(In reply to kumar rishav (:rishav_) from comment #5)
> Hi
> I am ready to take this bug. But i would like to give some suggestions .
> 1) It's good (in terms to visual look too) to have read/unread and delete in
> icons rather than in option mode.
> 2) Currently we are implementing the icons instead of text.
>
 
> My POV :
> * Long press on thread > select mode (instead of option dialog box) > from
> here as it is in bug 829820.
>
The long pressing behavior should be thread specific, because user is interacting with that particular thread. Check out the long press behavior in call log.
 
> * Setting icon  in top right corner and no need of 'more' icon (three
> horizontal dots)....as select thread mode will come in long press.
>  or
> setting icon in top left corner and 'more' icon (three dots) in top right
> corner...tapping on which take you to select more directly.
>
I'm planning on a new feature that would require the space on top left corner. So I'm afraid we need to keep the current design for now, but overall I agree with you.
 
> * we should remove confirmation or option selecting dialog box whereever
> it's possible.
> In email app too we go to edit mode in one tapping instead of option dialog
> box.
> 
> Thanks

Comment 9

[GitHub Autolander Bot]

Attachment: [PullReq] kumarrishav:Bug-1067275 to mozilla-b2g:master

Comment 10

[kumar rishav (:rishav_)]

Attachment: Patch

Hi Julien
Here is the patch. i tried my best to optmise and shorten whereever possible.
For now, only codes are there. will write unit test after positive feedback.
Thanks

Comment 11

[kumar rishav (:rishav_)]

Unit test also done :)

Comment 12

[Julien Wajsberg [:julienw]]

Comment on attachment 8553457 [details] [review]
Patch

Added comments on github.

Thanks for the work !

Comment 13

[kumar rishav (:rishav_)]

Comment on attachment 8553456 [details] [review]
[PullReq] kumarrishav:Bug-1067275 to mozilla-b2g:master

Hi Julien
Patch is ready.
I left the spliting of function for next bug (refactoring one). I just implemented this feature (bug).
Patch for which i asked feedback was to clarify if my codeflow is right or not. please don't mind those minor mistake. Anyway it should be ok now.

Thanks

Comment 14

[Julien Wajsberg [:julienw]]

> please don't mind those minor mistake.

Don't worry, I don't mind any mistake, everybody makes mistakes :) I wanted to point out every issue I could see so that you could work when I was away.

Comment 15

[Julien Wajsberg [:julienw]]

Hey Jenny, I have an additional question.

For accessibility reason, I think we should add a "enter thread" option in the context menu. The reason is that some people (older people, or people with cognitive issues) might longpress by mistake when they really want to enter a thread. That's why I think we could simply help them by adding this option to this longpress menu.

Comment 16

[Julien Wajsberg [:julienw]]

Comment on attachment 8553456 [details] [review]
[PullReq] kumarrishav:Bug-1067275 to mozilla-b2g:master

Hey Rishav,

thanks for the patch, this looks good :) I left comments in the patch, sorry again for the delay !

Comment 17

[kumar rishav (:rishav_)]

No worries, Was waiting for your review. Now i can sleep :)

Comment 18

[kumar rishav (:rishav_)]

Comment on attachment 8553456 [details] [review]
[PullReq] kumarrishav:Bug-1067275 to mozilla-b2g:master

+1 for comment 15

Comment 19

[Jenny Lee]

Hi Julien,

I personally prefer fine-tuning the "press and trigger" time to make it less likely for mistouch.
But let's have someone from Accessibility team to comment on this =)

Hi Eitan,

Can you take a look at comment 15 and let us know what you think?
In short, in SMS inbox, user can long press a thread to trigger a context menu to delete that thread, do you think we need to add a "enter the thread" option for accessibility reason? Thanks!

Comment 20

[Julien Wajsberg [:julienw]]

Comment on attachment 8553456 [details] [review]
[PullReq] kumarrishav:Bug-1067275 to mozilla-b2g:master

left more comments on github.

You should take more care as I already did some of these comments yesterday...

Comment 21

[Eitan Isaacson [:eeejay]]

(In reply to Jenny Lee from comment #19)
> Hi Julien,
> 
> I personally prefer fine-tuning the "press and trigger" time to make it less
> likely for mistouch.
> But let's have someone from Accessibility team to comment on this =)
> 
> Hi Eitan,
> 
> Can you take a look at comment 15 and let us know what you think?
> In short, in SMS inbox, user can long press a thread to trigger a context
> menu to delete that thread, do you think we need to add a "enter the thread"
> option for accessibility reason? Thanks!

My personal opinion is that we don't need an entry for that. I agree that the finger down time for a long press could be set to longer.

Comment 22

[Julien Wajsberg [:julienw]]

Comment on attachment 8553456 [details] [review]
[PullReq] kumarrishav:Bug-1067275 to mozilla-b2g:master

Just one simple comment, but I think it will be the last one !

Comment 23

[Julien Wajsberg [:julienw]]

BTW rishav, can you add your change in a separate commit? This would make it a lot easier to re-review :) Thanks !

Comment 24

[kumar rishav (:rishav_)]

Comment on attachment 8553456 [details] [review]
[PullReq] kumarrishav:Bug-1067275 to mozilla-b2g:master

Done.. hope it's okay now :)

Comment 25

[Julien Wajsberg [:julienw]]

Comment on attachment 8553456 [details] [review]
[PullReq] kumarrishav:Bug-1067275 to mozilla-b2g:master

small indentation issues , sorry...

Comment 26

[kumar rishav (:rishav_)]

Comment on attachment 8553456 [details] [review]
[PullReq] kumarrishav:Bug-1067275 to mozilla-b2g:master

Done. will squash once it's r+.
Thanks

Comment 27

[Julien Wajsberg [:julienw]]

Comment on attachment 8553456 [details] [review]
[PullReq] kumarrishav:Bug-1067275 to mozilla-b2g:master

r=me

please squash and add the keyword checkin-needed

thanks for the work and the patience!

Comment 28

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/ff92e1ab6ce599afd9974f6e150b921999ace314