106748 - When adding custom component, the description and size may be left blank

Status: VERIFIED FIXED

(CCK Graveyard :: CCK-Wizard, defect, P1)

Description

[Barrett Lindstrom]

I don't consider this a blocker by any means, but it's something to look at for 
the future.  

Currently, if you add a custom component, but do not add the description or the 
size, the component is added anyways, and the installer builds with no problems. 
 But the reported disk space needed by the installer is incorrect (offset by the 
actual size of the custom component).  I think there should be some sort of 
catch that forces users to add the name and size if one has not been given for 
the component.

Comment 1

[Barrett Lindstrom]

qa to blee

Comment 2

[Shruti Vasudevan]

Display error message if the user adds a custom component, but does not add the
description or the size.

Comment 3

[Shruti Vasudevan]

Attachment: Patch to display error message if description or size field is blank

In addition to displaying the error message, this patch also includes some
screen refinement.

Comment 4

[Shruti Vasudevan]

Attachment: Corresponding patch for factory

Comment 5

[Shruti Vasudevan]

Attachment: Screen shot of 'Create the installer' screen

Comment 6

[Steve Meredith (gone)]

I think you could be a little more descriptive in the code describing what 
IsFieldEmpty() does. Seems that the other parameters listed are only checked if 
the first parameter has a value. Is that right? 

This line in cckwiz/iniFiles/build_page1.ini looks suspect because IsFieldEmpty 
is in there twice: 

+onNext=IsFieldEmpty(%CustomComponentPath1%,%CustomComponentDesc1%,%
CustomComponentSize1%,Enter the description and size for the additional 
component);IsFieldEmpty(%CustomComponentPath2%,%CustomComponentDesc2%,%
CustomComponentSize2%,Enter the description and size for the additional 
component);Message(Are you ready to build your customized installer?);RunIB
();Msg(Installer creation is complete. The build is in %Root%Configs\%
CustomizationList%\Output)

This line in Factory's build_page1.ini looks suspect for the same reason as 
above and because the functions are in a different order than CCK's: 

+onNext=Message(Are you ready to build your customized installer?);IsFieldEmpty
(%CustomComponentPath1%,%CustomComponentDesc1%,%CustomComponentSize1%,Enter the 
description and size for the additional component);IsFieldEmpty(%
CustomComponentPath2%,%CustomComponentDesc2%,%CustomComponentSize2%,Enter the 
description and size for the additional component);RunIB();Msg(Installer 
creation is complete. The build is in %Root%Configs\%CustomizationList%\Output)
 
And I think you missed MyEnterprise/deploykit.che in Factory.

Comment 7

[Shruti Vasudevan]

>I think you could be a little more descriptive in the code describing what 
>IsFieldEmpty() does. 
I'll add a few more comments 

>Seems that the other parameters listed are only checked if 
>the first parameter has a value. Is that right? 
Yes.

>This line in cckwiz/iniFiles/build_page1.ini looks suspect because IsFieldEmpty 
>is in there twice
There are 2 additional components. So, I'm performing the check twice... once
for each component. 

>This line in Factory's build_page1.ini looks suspect for the same reason as 
>above and because the functions are in a different order than CCK's: 
good catch. I have accidentally put the functions in wrong order  for factory
and I have missed MyEnterprise/deploykit.che.

Comment 8

[Shruti Vasudevan]

Attachment: Corresponding patch for factory

Comment 9

[Shruti Vasudevan]

Attachment: Patch with more comments

Comment 10

[Steve Meredith (gone)]

r=smeredith

Comment 11

[Shruti Vasudevan]

Marking fixed.

Comment 12

[blee]

Verified in 5/8 CCK and NCADM blds.