1067504 - Make nsDocumentViewer::SetPrintPreviewPresentation correctly handle attaching to toplevel widgets

Status: RESOLVED FIXED

(Core :: Print Preview, defect)

Description

[Boris Zbarsky [:bzbarsky]]

This is needed for bug 927188.  Otherwise we never attach the print-preview presentation in the child process to the puppet widget and end up not painting it.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Hook up print preview to our parent widget as needed, so it will actually paint.

Comment 2

[Boris Zbarsky [:bzbarsky]]

It's not clear to me, by the way, whether it's best to do this, or to set it up in the print code wherever we create the viewmanager...   This seemed pretty sane and safe to me, though.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8489521 [details] [diff] [review]
Hook up print preview to our parent widget as needed, so it will actually paint.

Looks pretty sane. The view handling stuff in printengine doesn't currently
deal with printpreview explicitly, and since SetPrintPreviewPresentation
is explicitly for pp, this should be fine.

Other option is to modify nsDocumentViewer::MakeWindow and nsPrintEngine::SetRootView( quite a bit.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Yeah, I'm all in favor of not modifying things more than needed here.  ;)

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9db811d45df1