1067524 - Update WebGL2 IDL for recently removed constants

Status: RESOLVED WORKSFORME

(Core :: Graphics: CanvasWebGL, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

This, together with this pull request,

https://github.com/KhronosGroup/WebGL/pull/696

allows us to pass this WebGL2 conformance test:

https://www.khronos.org/registry/webgl/sdk/tests/conformance2/context/constants-and-properties-2.html

Comment 1

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: update-webidl-for-removed-constants

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

Oh, and this also comments out the mapBuffer entry points, which are not currently part of WebGL2 --- needed to pass another test.

Comment 3

[u480271]

Comment on attachment 8489557 [details] [diff] [review]
update-webidl-for-removed-constants

Review of attachment 8489557 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/webidl/WebGL2RenderingContext.webidl
@@ +545,4 @@
>      ArrayBuffer? mapBufferRange(GLenum target, GLintptr offset, GLsizeiptr length, GLbitfield access);
>      boolean unmapBuffer(GLenum target);
>      void flushMappedBufferRange(GLenum target, GLintptr offset, GLsizeiptr length);
> +    */

This should really be spec'd as an extension instead as part of the main WebGL2RenderingContext.

Comment 4

[Ethan Lin[:ethlin]]

All tests passed.