Update WebGL2 IDL for recently removed constants

RESOLVED WORKSFORME

Status

()

Core
Canvas: WebGL
RESOLVED WORKSFORME
3 years ago
2 years ago

People

(Reporter: bjacob, Unassigned)

Tracking

(Blocks: 1 bug)

Other Branch
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

This, together with this pull request,

https://github.com/KhronosGroup/WebGL/pull/696

allows us to pass this WebGL2 conformance test:

https://www.khronos.org/registry/webgl/sdk/tests/conformance2/context/constants-and-properties-2.html
(Reporter)

Comment 1

3 years ago
Created attachment 8489557 [details] [diff] [review]
update-webidl-for-removed-constants
Attachment #8489557 - Flags: review?(dglastonbury)
(Reporter)

Comment 2

3 years ago
Oh, and this also comments out the mapBuffer entry points, which are not currently part of WebGL2 --- needed to pass another test.
Comment on attachment 8489557 [details] [diff] [review]
update-webidl-for-removed-constants

Review of attachment 8489557 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/webidl/WebGL2RenderingContext.webidl
@@ +545,4 @@
>      ArrayBuffer? mapBufferRange(GLenum target, GLintptr offset, GLsizeiptr length, GLbitfield access);
>      boolean unmapBuffer(GLenum target);
>      void flushMappedBufferRange(GLenum target, GLintptr offset, GLsizeiptr length);
> +    */

This should really be spec'd as an extension instead as part of the main WebGL2RenderingContext.
Attachment #8489557 - Flags: review?(dglastonbury) → review+

Updated

2 years ago

Comment 4

2 years ago
All tests passed.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.