Closed Bug 1067538 Opened 6 years ago Closed 5 years ago

WebGL2: rename getQueryObject to getQueryParameter to adapt to spec change

Categories

(Core :: Canvas: WebGL, defect)

Other Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: bjacob, Unassigned)

References

Details

Attachments

(1 file)

Our WebGL2 query support from 1 year ago used OpenGL terminology, getQueryObject. The current WebGL2 spec/idl/tests expect this entry point to be named getQueryParameter instead.

This allows us to pass this test:
https://www.khronos.org/registry/webgl/sdk/tests/conformance2/context/methods-2.html?webglVersion=2
Attachment #8489562 - Flags: review?(dglastonbury)
I changed getQueryObject to getQueryParameter in the refresh of WebGl2RenderingContext.webidl in Bug 1002302.
Depends on: 1002302
Attachment #8489562 - Flags: review?(dglastonbury) → review+
When switching to getQueryParameter instead of getQueryObject my website crashes with example report: 
https://crash-stats.mozilla.com/report/index/bfa5df82-8722-4512-8ee4-5baf32141006
This seems fixed

(In reply to cstein from comment #2)
> When switching to getQueryParameter instead of getQueryObject my website
> crashes with example report: 
> https://crash-stats.mozilla.com/report/index/bfa5df82-8722-4512-8ee4-
> 5baf32141006

If this is still happening for you please open a new bug and cc me on it.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.