1067606 - Log in broken after account username converted

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect)

Description

[Mark Côté [:mcote]]

Since the fix for bug 1058786 landed, after you log in, your username will be converted from the email address that serves as your username in Bugzilla to your Bugzilla ID.  After this, you can still log in with your email address, but Review Board will automatically convert it, if found, to your username, which is then passed to rbbz's auth backend (the email address is passed as is if not found).

We just need to quickly look up the associated email address in BugzillaBackend.authenticate() if, say, username is an integer.

Comment 1

[Mark Côté [:mcote]]

Attachment: Look up email in BugzillaBackend.authenticate() if username is a user ID

This even handles users changing their username (email address) on Bugzilla *provided* that no user previously existed with that email *or* was already updated in Review Board.  So not quite perfect, but pretty close, and IMHO not worth an extra query to Bugzilla.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8489660 [details] [diff] [review]
Look up email in BugzillaBackend.authenticate() if username is a user ID

Review of attachment 8489660 [details] [diff] [review]:
-----------------------------------------------------------------

Let's do it.

Comment 3

[Mark Côté [:mcote]]

http://hg.mozilla.org/hgcustom/version-control-tools/rev/8e6f07248ece

Creating a new rbbz release shortly.