Enable VDA decoder in 10.6

RESOLVED FIXED in mozilla35

Status

()

Core
Audio/Video
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jya, Assigned: jya)

Tracking

Trunk
mozilla35
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

3 years ago
In Bug 1062654, VDA decoder was disabled in 10.6 as it often crashes (and in particular the gizmo.mp4 video found in the mochitest)

VDA should be working in 10.6 too.
(Assignee)

Comment 1

3 years ago
Created attachment 8489806 [details] [diff] [review]
Work around 10.6 VDA bug

Re-enable VDA on 10.6. Work around retain/release error in 10.6
Attachment #8489806 - Flags: review?(giles)
(Assignee)

Comment 2

3 years ago
https://tbpl.mozilla.org/?tree=Try&rev=6b78bd0ef5f9
(Assignee)

Updated

3 years ago
Attachment #8489806 - Attachment is obsolete: true
Attachment #8489806 - Flags: review?(giles)
(Assignee)

Comment 3

3 years ago
Created attachment 8489815 [details] [diff] [review]
Work around 10.6 VDA bug

Re-enable VDA on 10.6. Work around retain/release error in 10.6
Attachment #8489815 - Flags: review?(giles)
(Assignee)

Comment 4

3 years ago
https://tbpl.mozilla.org/?tree=Try&rev=03a55701a640
(Assignee)

Comment 5

3 years ago
Created attachment 8489850 [details] [diff] [review]
Account for fmp4 now potentially working on MacOS X 10.6

Update mochitest for 10.6
Attachment #8489850 - Flags: review?(cpearce)
(Assignee)

Comment 6

3 years ago
https://tbpl.mozilla.org/?tree=Try&rev=bed3070c9d12
Attachment #8489850 - Flags: review?(cpearce) → review+
Comment on attachment 8489815 [details] [diff] [review]
Work around 10.6 VDA bug

Review of attachment 8489815 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nit addressed.

::: content/media/fmp4/apple/AppleVDADecoder.h
@@ +49,5 @@
>    virtual nsresult Shutdown() MOZ_OVERRIDE;
>  
>    nsresult OutputFrame(CVPixelBufferRef aImage,
>                         nsAutoPtr<AppleFrameRef> aFrameRef);
> +  bool mIs106;

This can be private, no?
Attachment #8489815 - Flags: review?(giles) → review+
(Assignee)

Comment 8

3 years ago
Created attachment 8491202 [details] [diff] [review]
Work around 10.6 VDA bug

Carrying r+. Remove use of Gestalt. Make variable private
(Assignee)

Updated

3 years ago
Attachment #8489815 - Attachment is obsolete: true
(Assignee)

Comment 9

3 years ago
https://tbpl.mozilla.org/?tree=Try&rev=ae729351d0c3
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
(Assignee)

Updated

3 years ago
Blocks: 1068597
https://hg.mozilla.org/integration/mozilla-inbound/rev/a73501f2bd94
https://hg.mozilla.org/integration/mozilla-inbound/rev/612de448f2cf
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a73501f2bd94
https://hg.mozilla.org/mozilla-central/rev/612de448f2cf
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.