Closed
Bug 1067697
Opened 10 years ago
Closed 10 years ago
Enable VDA decoder in 10.6
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla35
People
(Reporter: jya, Assigned: jya)
References
Details
Attachments
(2 files, 2 obsolete files)
2.08 KB,
patch
|
cpearce
:
review+
|
Details | Diff | Splinter Review |
6.32 KB,
patch
|
Details | Diff | Splinter Review |
In Bug 1062654, VDA decoder was disabled in 10.6 as it often crashes (and in particular the gizmo.mp4 video found in the mochitest) VDA should be working in 10.6 too.
Assignee | ||
Comment 1•10 years ago
|
||
Re-enable VDA on 10.6. Work around retain/release error in 10.6
Attachment #8489806 -
Flags: review?(giles)
Assignee | ||
Comment 2•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=6b78bd0ef5f9
Assignee | ||
Updated•10 years ago
|
Attachment #8489806 -
Attachment is obsolete: true
Attachment #8489806 -
Flags: review?(giles)
Assignee | ||
Comment 3•10 years ago
|
||
Re-enable VDA on 10.6. Work around retain/release error in 10.6
Attachment #8489815 -
Flags: review?(giles)
Assignee | ||
Comment 4•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=03a55701a640
Assignee | ||
Comment 5•10 years ago
|
||
Update mochitest for 10.6
Attachment #8489850 -
Flags: review?(cpearce)
Assignee | ||
Comment 6•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=bed3070c9d12
Updated•10 years ago
|
Attachment #8489850 -
Flags: review?(cpearce) → review+
Comment 7•10 years ago
|
||
Comment on attachment 8489815 [details] [diff] [review] Work around 10.6 VDA bug Review of attachment 8489815 [details] [diff] [review]: ----------------------------------------------------------------- r=me with nit addressed. ::: content/media/fmp4/apple/AppleVDADecoder.h @@ +49,5 @@ > virtual nsresult Shutdown() MOZ_OVERRIDE; > > nsresult OutputFrame(CVPixelBufferRef aImage, > nsAutoPtr<AppleFrameRef> aFrameRef); > + bool mIs106; This can be private, no?
Attachment #8489815 -
Flags: review?(giles) → review+
Assignee | ||
Comment 8•10 years ago
|
||
Carrying r+. Remove use of Gestalt. Make variable private
Assignee | ||
Updated•10 years ago
|
Attachment #8489815 -
Attachment is obsolete: true
Assignee | ||
Comment 9•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=ae729351d0c3
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 10•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a73501f2bd94 https://hg.mozilla.org/integration/mozilla-inbound/rev/612de448f2cf
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a73501f2bd94 https://hg.mozilla.org/mozilla-central/rev/612de448f2cf
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in
before you can comment on or make changes to this bug.
Description
•