Closed Bug 1067697 Opened 6 years ago Closed 6 years ago

Enable VDA decoder in 10.6

Categories

(Core :: Audio/Video, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: jya, Assigned: jya)

References

Details

Attachments

(2 files, 2 obsolete files)

In Bug 1062654, VDA decoder was disabled in 10.6 as it often crashes (and in particular the gizmo.mp4 video found in the mochitest)

VDA should be working in 10.6 too.
Attached patch Work around 10.6 VDA bug (obsolete) — Splinter Review
Re-enable VDA on 10.6. Work around retain/release error in 10.6
Attachment #8489806 - Flags: review?(giles)
Attachment #8489806 - Attachment is obsolete: true
Attachment #8489806 - Flags: review?(giles)
Attached patch Work around 10.6 VDA bug (obsolete) — Splinter Review
Re-enable VDA on 10.6. Work around retain/release error in 10.6
Attachment #8489815 - Flags: review?(giles)
Update mochitest for 10.6
Attachment #8489850 - Flags: review?(cpearce)
Attachment #8489850 - Flags: review?(cpearce) → review+
Comment on attachment 8489815 [details] [diff] [review]
Work around 10.6 VDA bug

Review of attachment 8489815 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nit addressed.

::: content/media/fmp4/apple/AppleVDADecoder.h
@@ +49,5 @@
>    virtual nsresult Shutdown() MOZ_OVERRIDE;
>  
>    nsresult OutputFrame(CVPixelBufferRef aImage,
>                         nsAutoPtr<AppleFrameRef> aFrameRef);
> +  bool mIs106;

This can be private, no?
Attachment #8489815 - Flags: review?(giles) → review+
Carrying r+. Remove use of Gestalt. Make variable private
Attachment #8489815 - Attachment is obsolete: true
Keywords: checkin-needed
Blocks: 1068597
You need to log in before you can comment on or make changes to this bug.