1067710 - console.table() column limit should match Chrome's

Status: RESOLVED FIXED

(DevTools :: Console, defect, P2)

Description

[u443210]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:35.0) Gecko/20100101 Firefox/35.0
Build ID: 20140915030204

Steps to reproduce:

-Open the web console.
-Copy and paste this: 

     foo = {
	bar1: {
		prop1: 1,
		prop2: 2,
		prop3: 3,
		prop4: 4,
		prop5: 5,
		prop6: 6,
		prop7: 7,
		prop8: 8,
		prop9: 9,
		prop10: 10,
		prop11: 11,
		prop12: 12,
		prop13: 13,
		prop14: 14,
		prop15: 15,
		prop16: 16,
		prop17: 17,
		prop18: 18,
		prop19: 19,
		prop20: 20
	},

	bar2: {
		prop1: 1,
		prop2: 2,
		prop3: 3,
		prop4: 4,
		prop5: 5,
		prop6: 6,
		prop7: 7,
		prop8: 8,
		prop9: 9,
		prop10: 10,
		prop11: 11,
		prop12: 12,
		prop13: 13,
		prop14: 14,
		prop15: 15,
		prop16: 16,
		prop17: 17,
		prop18: 18,
		prop19: 19,
		prop20: 20
	}
    }
    console.table(foo)


Actual results:

The max number of columns displayed is 10.


Expected results:

Should not have a limit number of columns.

Comment 1

[Scott Trenda]

+1. I know this is a newer feature for dev tools, but limiting the number of columns makes it really confusing if you're inspecting an object with more properties than that limit, with no indication that there are more properties on the object than are enumerated in the table.

Comment 2

[Tom Tromey :tromey]

I wonder what the correct behavior would be.
Also I note that Chrome allows 20 columns.

For the new console the value seems readily changed, but my naive attempt did not immediately work.
https://dxr.mozilla.org/mozilla-central/rev/e03e0c60462c775c7558a1dc9d5cf2076c3cd1f9/devtools/client/webconsole/new-console-output/components/console-table.js#19

Comment 3

[Frank Forte]

Ideally, text in the table cells can wrap to more than one line (which could leave room for more columns, and fixes the problem of content being cut off with no way to access the cell contents).

Alternatively just show the first X characters of each cell, and show the full cell content when the content is clicked.

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1067710 - Bump console.table columns limit to 21 to match Chrome. r=Honza.

Increasing the number of columnns highlighted some issues:

• Some element could be off-screen, the grid-template-columns
  needed to be adjusted
• headers could be cut-off, we add a title on the element to
  have the full content in a tooltip
• properties that are not defined were displayed as "undefined",
  which is not really true, and take a lot of space. We render
  them as an empty cell in such case now.

A test is added to check the max-column limit.

Depends on D53962

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e0c4b949057
Bump console.table columns limit to 21 to match Chrome. r=Honza.

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/6e0c4b949057