1067744 - Make GMPMutex reentrant

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

Apparently a lot of Adobe's code that they want to import into their GMP uses reentrant mutexes. So they'd appreciate it if we made GMPMutex reentrant.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch

Make GMPMutex reentrant to save Adobe some work...

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8489805 [details] [diff] [review]
Patch

Review of attachment 8489805 [details] [diff] [review]:
-----------------------------------------------------------------

Maybe add a comment why GMPMutex is a monitor, and that it's re-entrant

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

I added a comment. Thanks!

https://hg.mozilla.org/integration/mozilla-inbound/rev/e8a1c2b11f71

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Bustage fix...
https://hg.mozilla.org/integration/mozilla-inbound/rev/ded4fbea408f

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e8a1c2b11f71
https://hg.mozilla.org/mozilla-central/rev/ded4fbea408f

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

Mass update firefox-status to track EME uplift.