Make GMPMutex reentrant

RESOLVED FIXED in Firefox 37

Status

()

Core
Audio/Video
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: cpearce, Assigned: cpearce)

Tracking

(Blocks: 2 bugs)

Trunk
mozilla35
x86_64
All
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox37 fixed, firefox38 fixed, firefox39 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Apparently a lot of Adobe's code that they want to import into their GMP uses reentrant mutexes. So they'd appreciate it if we made GMPMutex reentrant.
(Assignee)

Comment 1

3 years ago
Created attachment 8489805 [details] [diff] [review]
Patch

Make GMPMutex reentrant to save Adobe some work...
Attachment #8489805 - Flags: review?(rjesup)
Comment on attachment 8489805 [details] [diff] [review]
Patch

Review of attachment 8489805 [details] [diff] [review]:
-----------------------------------------------------------------

Maybe add a comment why GMPMutex is a monitor, and that it's re-entrant
Attachment #8489805 - Flags: review?(rjesup) → review+
(Assignee)

Comment 3

3 years ago
I added a comment. Thanks!

https://hg.mozilla.org/integration/mozilla-inbound/rev/e8a1c2b11f71
(Assignee)

Comment 4

3 years ago
Bustage fix...
https://hg.mozilla.org/integration/mozilla-inbound/rev/ded4fbea408f
https://hg.mozilla.org/mozilla-central/rev/e8a1c2b11f71
https://hg.mozilla.org/mozilla-central/rev/ded4fbea408f
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
(Assignee)

Comment 6

3 years ago
Mass update firefox-status to track EME uplift.
status-firefox37: --- → fixed
status-firefox38: --- → fixed
status-firefox39: --- → fixed
You need to log in before you can comment on or make changes to this bug.