1067772 - (app-grouping) Naming/renaming groups

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Cristian Rodriguez (:crdlc)]

As user I want to name/rename groups

Comment 1

[Cristian Rodriguez (:crdlc)]

I take this feature although if someone wants to take it please tell me, thanks

Comment 2

[Cristian Rodriguez (:crdlc)]

Hi Maria, please when the new spec for "editing group names" UI is ready, please let me know. Thanks a lot

Comment 3

[Maria Sandberg [:mushi]]

Hi Cristian. I'm working on updating the spec today but need to check in with the UX team on what the exact pattern for the rename should be. I'll get back to you as soon as I have it, leaving the needinfo as a reminder.

Comment 4

[Cristian Rodriguez (:crdlc)]

WIP based on Chris' implementation and pending of UX spec

Video demo: http://youtu.be/s4mUTUgoJwc

Branch: https://github.com/crdlc/gaia/tree/grouping-2-names
Patch:
https://github.com/crdlc/gaia/commit/c996d2a902e996c70f4d49f1b2f9a5595f1668
d5

Comment 5

[Chris Lord [:cwiiis]]

(In reply to Cristian Rodriguez (:crdlc) from comment #4)
> WIP based on Chris' implementation and pending of UX spec
> 
> Video demo: http://youtu.be/s4mUTUgoJwc
> 
> Branch: https://github.com/crdlc/gaia/tree/grouping-2-names
> Patch:
> https://github.com/crdlc/gaia/commit/c996d2a902e996c70f4d49f1b2f9a5595f1668
> d5

Nice :)

Comment 6

[Maria Sandberg [:mushi]]

I've managed to super-break my device and can't take a look at the patch right now but the video looks great. We are still discussing the pattern for renaming but most likely we will not use any type of icon for the edit name screen of a group. Let's just leave it as implemented in the proto for now.

Comment 7

[Cristian Rodriguez (:crdlc)]

Code ready once landed bug 1067435

https://github.com/crdlc/gaia/commit/6776e524cf6922cb4f679d7bba111487901db044

Comment 8

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

Thanks guys for this review

Comment 9

[Maria Sandberg [:mushi]]

Quick question - do we have an estimate for when this piece might land? It would help me decide whether to wait until we have everything before asking UX for feedback.

Comment 10

[Kevin Grandon :kgrandon]

(In reply to Maria Sandberg [:mushi] from comment #9)
> Quick question - do we have an estimate for when this piece might land? It
> would help me decide whether to wait until we have everything before asking
> UX for feedback.

It's in review, so hopefully by Friday, at worst probably early next week. I'd say it probably makes sense to hold off on UX feedback until this lands.

Comment 11

[Kevin Grandon :kgrandon]

Comment on attachment 8495086 [details]
Github pull request

Nice work. I left some thoughts on github, but nothing that should really prevent this from landing. I also noticed that we had a failing intermittent test on gaia-try. I made a few re-triggers, but if this causes that test to fail, please address before landing. I'll go ahead and leave an R+ here assuming there's nothing major needed for the test, but feel free to re-flag me if you feel it necessary.

Thanks for the quick work on this.

Comment 12

[Cristian Rodriguez (:crdlc)]

Hi Kevin, addressed/answered comments. Thanks

Comment 13

[Chris Lord [:cwiiis]]

Comment on attachment 8495086 [details]
Github pull request

Nice work, really clean and great test coverage :) I have some comments, but same as Kevin, nothing that would stop it landing.

Comment 14

[Cristian Rodriguez (:crdlc)]

Comments addressed, waiting for green again :)

Comment 15

[Cristian Rodriguez (:crdlc)]

Merged in master:

https://github.com/mozilla-b2g/gaia/commit/44c06869d9cf80d74157ea94b161b572f918a793

Comment 16

[Maria Sandberg [:mushi]]

Awesome, thanks all. Assuming this will show up in the B2G flash tool tomorrow (Tuesday) morning PST? :)

Comment 17

[Cristian Rodriguez (:crdlc)]

I think so :) Although I don't know when builds are done there. In the worst case you can check this Wednesday for sure

(In reply to Maria Sandberg [:mushi] from comment #16)
> Awesome, thanks all. Assuming this will show up in the B2G flash tool
> tomorrow (Tuesday) morning PST? :)

Comment 18

[Yeojin Chung [:YeojinC]]

Unable to verify this issue as group naming is no longer a feature, according to https://bugzilla.mozilla.org/show_bug.cgi?id=1069705#c3.