Closed
Bug 1067845
Opened 10 years ago
Closed 10 years ago
Clean up after browser_mozLoop_softStart.js
Categories
(Hello (Loop) :: Client, defect)
Hello (Loop)
Client
Tracking
(firefox34 fixed, firefox35 fixed)
RESOLVED
FIXED
mozilla35
People
(Reporter: Paolo, Assigned: Paolo)
References
Details
(Whiteboard: [loop-uplift])
Attachments
(1 file)
1.36 KB,
patch
|
abr
:
review+
lmandel
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
browser_mozLoop_softStart.js is executed in the browser-chrome test environment together with all other tests, thus it should revert preference changes when finished.
Attachment #8489897 -
Flags: review?(adam)
Comment 1•10 years ago
|
||
Comment on attachment 8489897 [details] [diff] [review]
The patch
Review of attachment 8489897 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks.
Attachment #8489897 -
Flags: review?(adam) → review+
Assignee | ||
Comment 2•10 years ago
|
||
Assignee: nobody → paolo.mozmail
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Comment 4•10 years ago
|
||
Comment on attachment 8489897 [details] [diff] [review]
The patch
Approval Request Comment
Uplift request for patches staged and tested on Fig
Attachment #8489897 -
Flags: approval-mozilla-aurora?
Comment 5•10 years ago
|
||
Updated•10 years ago
|
status-firefox34:
--- → fixed
status-firefox35:
--- → fixed
Comment 6•10 years ago
|
||
Comment on attachment 8489897 [details] [diff] [review]
The patch
I worked with Randell and Maire on uplifting a large number of Loop bugs at once. All of the bugs have been staged on Fig and tested by QE before uplift to Aurora. As well, all of the bugs are isolated to the Loop client. Randell handled the uplift with my approval. I am adding approval to the bug after the fact for bookkeeping.
Attachment #8489897 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in
before you can comment on or make changes to this bug.
Description
•